[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling
URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r186846020
 
 

 ##########
 File path: tests/python/gpu/test_operator_gpu.py
 ##########
 @@ -745,7 +745,7 @@ def test_pooling_with_type():
 @with_seed()
 def test_pooling_versions():
     def test_pooling_versions_helper(pool_op_list, data, kernel, pool_type, pad, stride,
-                                     pooling_convention='valid', global_pool=False):
+                                     pooling_convention='valid', global_pool=False, p_value=2):
 
 Review comment:
   The most commonly used case for Lp pooling is p=2, for all other types of pooling this value is not used at all, so there's no side effect on other types of pooling with setting p_value to be 2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services