[GitHub] [flink] tillrohrmann commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293347218
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
 ##########
 @@ -48,6 +50,18 @@
 	/** Flag whether the result partition should send scheduleOrUpdateConsumer messages. */
 	private final boolean sendScheduleOrUpdateConsumersMessage;
 
+	/** Whether the result partition is managed externally.
+	 *
+	 * <p>An externally managed partition is only released if either
+	 * a) the {@link ShuffleEnvironment} is instructed to do so via {@link ShuffleEnvironment#releasePartitions(Collection)},
+	 * b) the production of the partition fails,
+	 * c) the {@link ShuffleEnvironment} shuts down.
 
 Review comment:
   I think the formatting would be better if we used `<ul><li></li>...</ul>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services