[GitHub] [tvm] Lyken17 commented on a change in pull request #9465: [Conv2DTransposed] Fix wrong shape check and add new TOPI module to support groups

[GitBox <gi...@apache.org>]

Lyken17 commented on a change in pull request #9465:
URL: https://github.com/apache/tvm/pull/9465#discussion_r747569408



##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -281,13 +281,25 @@ def conv2d_transpose_strategy_cpu(attrs, inputs, out_type, target):
     groups = attrs.groups
     assert layout == "NCHW", "only support nchw for now"
     assert dilation == (1, 1), "not support dilate now"
-    assert groups == 1, "only support groups == 1 for now"
+    # assert groups == 1, "only support groups == 1 for now"

Review comment:
       Removed

##########
File path: python/tvm/relay/op/strategy/generic.py
##########
@@ -471,13 +475,20 @@ def conv2d_transpose_strategy(attrs, inputs, out_type, target):
     groups = attrs.groups
     assert layout == "NCHW", "only support nchw for now"
     assert dilation == (1, 1), "not support dilate now"
-    assert groups == 1, "only support groups == 1 for now"
+    # assert groups == 1, "only support groups == 1 for now"

Review comment:
       removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org