You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/12 06:59:41 UTC
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16444
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
[rpc] simplify Connection::GetNextCallId()
This changelist simplifies the code to compute next call identifier.
Synthetic performance results look good, no performance degradation
is observed.
Before:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
9264.974859 task-clock # 9.045 CPUs utilized ( +- 0.69% )
87,544 context-switches # 0.009 M/sec ( +- 1.28% )
1,452 cpu-migrations # 0.157 K/sec ( +- 20.67% )
3,216 page-faults # 0.347 K/sec ( +- 1.05% )
26,213,352,542 cycles # 2.829 GHz ( +- 0.73% )
27,520,087,657 instructions # 1.05 insns per cycle ( +- 1.27% )
4,375,784,153 branches # 472.293 M/sec ( +- 1.25% )
22,713,237 branch-misses # 0.52% of all branches ( +- 1.20% )
1.024363805 seconds time elapsed ( +- 0.05% )
After:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
8744.870402 task-clock # 8.540 CPUs utilized ( +- 3.32% )
86,214 context-switches # 0.010 M/sec ( +- 2.94% )
1,518 cpu-migrations # 0.174 K/sec ( +- 22.82% )
3,183 page-faults # 0.364 K/sec ( +- 1.19% )
24,708,133,421 cycles # 2.825 GHz ( +- 3.36% )
25,856,687,203 instructions # 1.05 insns per cycle ( +- 3.76% )
4,111,319,492 branches # 470.141 M/sec ( +- 3.74% )
21,390,733 branch-misses # 0.52% of all branches ( +- 3.66% )
1.023946171 seconds time elapsed ( +- 0.05% )
Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
---
M src/kudu/rpc/connection.h
1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/16444/1
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295
PS1, Line 295: 0x7fffffff
> Why hardcode a mask?
The idea of using a number in hexadecimal for the bitmask here is to be explicit on how it works bitwise.
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 13 Sep 2020 00:14:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h@296
PS2, Line 296: ++next_call_id_
> As far as I can see, there isn't any significance in what's the first call
After you pointed to the initial call ID assignment, I realized it makes sense to unify the way how call IDs are assigned before and after rolling over the maximum possible one. I also renamed next_call_id_ to call_id_cnt_ to avoid confusion: as stated in the comment for the member field, that's just a counter to derive next call identifier from it (the code of GetNextCallId() is clear enough to see what's going on there).
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Sep 2020 04:14:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16444
to look at the new patch set (#3).
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
[rpc] simplify Connection::GetNextCallId()
This changelist simplifies the code to compute next call identifier.
Synthetic performance results look good, no performance degradation
is observed.
Before:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
9264.974859 task-clock # 9.045 CPUs utilized ( +- 0.69% )
87,544 context-switches # 0.009 M/sec ( +- 1.28% )
1,452 cpu-migrations # 0.157 K/sec ( +- 20.67% )
3,216 page-faults # 0.347 K/sec ( +- 1.05% )
26,213,352,542 cycles # 2.829 GHz ( +- 0.73% )
27,520,087,657 instructions # 1.05 insns per cycle ( +- 1.27% )
4,375,784,153 branches # 472.293 M/sec ( +- 1.25% )
22,713,237 branch-misses # 0.52% of all branches ( +- 1.20% )
1.024363805 seconds time elapsed ( +- 0.05% )
After:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
8744.870402 task-clock # 8.540 CPUs utilized ( +- 3.32% )
86,214 context-switches # 0.010 M/sec ( +- 2.94% )
1,518 cpu-migrations # 0.174 K/sec ( +- 22.82% )
3,183 page-faults # 0.364 K/sec ( +- 1.19% )
24,708,133,421 cycles # 2.825 GHz ( +- 3.36% )
25,856,687,203 instructions # 1.05 insns per cycle ( +- 3.76% )
4,111,319,492 branches # 470.141 M/sec ( +- 3.74% )
21,390,733 branch-misses # 0.52% of all branches ( +- 3.66% )
1.023946171 seconds time elapsed ( +- 0.05% )
Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
2 files changed, 10 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/16444/3
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1: Verified+1
unrelated test failure in TabletCopyClientTest.TestLifeCycle
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 12 Sep 2020 17:34:15 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h@296
PS2, Line 296: ++next_call_id_
Before this change, the returned values for GetNextCallId() would start from 1 and now it would start from 2, considering next_call_id_ is initialized with 1.
Moreover meaning of next_call_id_ is changed and should be named curr_call_id_ instead and it should start from 0 instead to keep the return values functionally same as before this change, no?
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Sep 2020 01:19:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295
PS1, Line 295: 0x7fffffff
> The idea of using a number in hexadecimal for the bitmask here is to be exp
After some consideration, I updated the code, adding the value in hexadecimal notation as a comment. I also switched to using prefix operator to spare one register :)
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 13 Sep 2020 04:33:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h@296
PS2, Line 296: ++next_call_id_
> Before this change, the returned values for GetNextCallId() would start fro
As far as I can see, there isn't any significance in what's the first call id for the connection: the original code would return 0 after rolling it over MAX_INT. After my change, no test failed.
I don't think renaming next_call_id_ to curr_call_id_ makes it any clearer.
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Sep 2020 03:47:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295
PS1, Line 295: 0x7fffffff
Nit: It'd be better to use the numeric_limits instead of this constant for mask.
static constexpr uint32_t mask = std::numeric_limits<int32_t>::max();
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 12 Sep 2020 23:58:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295
PS1, Line 295: 0x7fffffff
> Why do you think it's better?
Why hardcode a mask?
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 13 Sep 2020 00:01:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Sep 2020 04:54:10 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h
File src/kudu/rpc/connection.h:
http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295
PS1, Line 295: 0x7fffffff
> Nit: It'd be better to use the numeric_limits instead of this constant for
Why do you think it's better?
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 13 Sep 2020 00:00:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16444
to look at the new patch set (#2).
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
[rpc] simplify Connection::GetNextCallId()
This changelist simplifies the code to compute next call identifier.
Synthetic performance results look good, no performance degradation
is observed.
Before:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
9264.974859 task-clock # 9.045 CPUs utilized ( +- 0.69% )
87,544 context-switches # 0.009 M/sec ( +- 1.28% )
1,452 cpu-migrations # 0.157 K/sec ( +- 20.67% )
3,216 page-faults # 0.347 K/sec ( +- 1.05% )
26,213,352,542 cycles # 2.829 GHz ( +- 0.73% )
27,520,087,657 instructions # 1.05 insns per cycle ( +- 1.27% )
4,375,784,153 branches # 472.293 M/sec ( +- 1.25% )
22,713,237 branch-misses # 0.52% of all branches ( +- 1.20% )
1.024363805 seconds time elapsed ( +- 0.05% )
After:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
8744.870402 task-clock # 8.540 CPUs utilized ( +- 3.32% )
86,214 context-switches # 0.010 M/sec ( +- 2.94% )
1,518 cpu-migrations # 0.174 K/sec ( +- 22.82% )
3,183 page-faults # 0.364 K/sec ( +- 1.19% )
24,708,133,421 cycles # 2.825 GHz ( +- 3.36% )
25,856,687,203 instructions # 1.05 insns per cycle ( +- 3.76% )
4,111,319,492 branches # 470.141 M/sec ( +- 3.74% )
21,390,733 branch-misses # 0.52% of all branches ( +- 3.66% )
1.023946171 seconds time elapsed ( +- 0.05% )
Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
---
M src/kudu/rpc/connection.h
1 file changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/16444/2
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rpc] simplify Connection::GetNextCallId()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId()
......................................................................
[rpc] simplify Connection::GetNextCallId()
This changelist simplifies the code to compute next call identifier.
Synthetic performance results look good, no performance degradation
is observed.
Before:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
9264.974859 task-clock # 9.045 CPUs utilized ( +- 0.69% )
87,544 context-switches # 0.009 M/sec ( +- 1.28% )
1,452 cpu-migrations # 0.157 K/sec ( +- 20.67% )
3,216 page-faults # 0.347 K/sec ( +- 1.05% )
26,213,352,542 cycles # 2.829 GHz ( +- 0.73% )
27,520,087,657 instructions # 1.05 insns per cycle ( +- 1.27% )
4,375,784,153 branches # 472.293 M/sec ( +- 1.25% )
22,713,237 branch-misses # 0.52% of all branches ( +- 1.20% )
1.024363805 seconds time elapsed ( +- 0.05% )
After:
Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs):
8744.870402 task-clock # 8.540 CPUs utilized ( +- 3.32% )
86,214 context-switches # 0.010 M/sec ( +- 2.94% )
1,518 cpu-migrations # 0.174 K/sec ( +- 22.82% )
3,183 page-faults # 0.364 K/sec ( +- 1.19% )
24,708,133,421 cycles # 2.825 GHz ( +- 3.36% )
25,856,687,203 instructions # 1.05 insns per cycle ( +- 3.76% )
4,111,319,492 branches # 470.141 M/sec ( +- 3.74% )
21,390,733 branch-misses # 0.52% of all branches ( +- 3.66% )
1.023946171 seconds time elapsed ( +- 0.05% )
Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Reviewed-on: http://gerrit.cloudera.org:8080/16444
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
2 files changed, 10 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53
Gerrit-Change-Number: 16444
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)