You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:37:21 UTC

[GitHub] [spark] manuzhang opened a new pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

manuzhang opened a new pull request #28770:
URL: https://github.com/apache/spark/pull/28770


   ### What changes were proposed in this pull request?
   This reverts commit https://github.com/apache/spark/commit/b9737c3c228f465d332e41f1ea0cece2a5f7667e while keeping following changes
   
   * set default value of `spark.sql.adaptive.skewJoin.skewedPartitionFactor` to 5
   * tests
   * remove unused imports
   
   ### Why are the changes needed?
   As discussed in https://github.com/apache/spark/pull/28669#issuecomment-641044531, revert SPARK-31864 for optimizing skew join to work for extremely clustered keys.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Existing tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #28770: [SPARK-31942] Partially revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28770:
URL: https://github.com/apache/spark/pull/28770


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641865258


   **[Test build #123748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123748/testReport)** for PR 28770 at commit [`f806c9a`](https://github.com/apache/spark/commit/f806c9a6975cd93589677947b441d4af68e2a64b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641865258


   **[Test build #123748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123748/testReport)** for PR 28770 at commit [`f806c9a`](https://github.com/apache/spark/commit/f806c9a6975cd93589677947b441d4af68e2a64b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641865911






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641865911






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641863437






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641242421






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-642104571


   **[Test build #123748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123748/testReport)** for PR 28770 at commit [`f806c9a`](https://github.com/apache/spark/commit/f806c9a6975cd93589677947b441d4af68e2a64b).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641242421






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-642106637






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28770: [SPARK-31942] Partially revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-642385395


   thanks, merging to master!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641244156


   OK to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28770: [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-642106637






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org