You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/10/23 07:18:46 UTC
[I] ci: Add yaml formatter [incubator-opendal]
Xuanwo opened a new issue, #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361
We now have numerous yaml files in our repository, including GitHub workflows and Docker compose files. To avoid conflicts over varying format styles, it would be beneficial to add a yaml formatter in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774797677
> Since syntax such as indentation is semantic to YAML, we should probably pay attention to formatting when coding. So formatting may be of limited benefit to YAML.
I didn't understand. Python's indentation is also semantic, but the code format in Python remains significant. It's an error if the semantics change after formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774731022
> Add .idea/.vscode.jpg plz
I don't believe that's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1775057640
🤔 Adding a format check is an easy job.
We could add it to let our developers to pay some attention to formatting.
We can also provide some additional local tool candidates to help with these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1775105093
> 🤔 Adding a format check is an easy job.
>
> We could add it to let our developers to pay some attention to formatting.
>
> We can also provide some additional local tool candidates to help with these.
Personally, I don't want to add extra work for our developers too. It looks good to me to format yaml files from time to time.
Maybe we can start with a simple PR that format all yaml files first? And we can add such tool in CI in the future. (Like what we did for cargo +nightly fmt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774765322
How profitable is this one? What goal do we want to achieve?
Since syntax such as indentation is semantic to YAML, we should probably pay attention to formatting when coding. So formatting may be of limited benefit to YAML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774720704
> I think add some editor/IDE config would be better to help people reach the same style
We already have `.editorconfig` but seems not work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1775756113
Good enough, let's close. We can bring yanlfmt into CI in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Zheaoli (via GitHub)" <gi...@apache.org>.
Zheaoli commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774716541
I think add some editor/IDE config would be better to help people reach the same style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Zheaoli (via GitHub)" <gi...@apache.org>.
Zheaoli commented on issue #3361:
URL: https://github.com/apache/incubator-opendal/issues/3361#issuecomment-1774729041
> We already have .editorconfig but seems not work well.
Add .idea/.vscode.jpg plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ci: Add yaml formatter [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #3361: ci: Add yaml formatter
URL: https://github.com/apache/incubator-opendal/issues/3361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org