[jira] [Commented] (PROTON-700) small performance improvement from inling one fn.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148234#comment-14148234 ] 

ASF subversion and git services commented on PROTON-700:
--------------------------------------------------------

Commit 1627642 from [~mgoulish] in branch 'proton/trunk'
[ https://svn.apache.org/r1627642 ]

PROTON-700 : small performance improvement from inlining pn_data_node().
This is a very popular function.
improvement on newer box was 6% , on older box 2.6%
t-test after 50 reps before & after says odd of the 2.6% figure
happening by chance is 2.0e-18 .

> small performance improvement from inling one fn.
> -------------------------------------------------
>
>                 Key: PROTON-700
>                 URL: https://issues.apache.org/jira/browse/PROTON-700
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>            Reporter: michael goulish
>            Assignee: michael goulish
>            Priority: Minor
>
> inlining the internal function pn_data_node()  improves speed somewhere between 2.6% and 6%, depending on architecture.
> This is based on testing I did with two C-based clients written at the engine interface level.
> The higher 6% figure was seen on a more modern machine with recent Intel processors, the lower figure was seen on an older box with AMD processors.
> But the effect is real: after 5- repetition before the change & 50 after, T-test indicates odds of this happening by chance is 2.0e-18 .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)