You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/08/09 21:11:02 UTC

Review Request: SQOOP-568: Configuration reload period should be configurable in PropertiesConfigurationProvider

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6498/
-----------------------------------------------------------

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Description
-------

I've created new configuration option and propagate it to aConfigFilePoller thread.


This addresses bug SQOOP-568.
    https://issues.apache.org/jira/browse/SQOOP-568


Diffs
-----

  /branches/sqoop2/core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 1371304 
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java 1371304 
  /branches/sqoop2/dist/src/main/server/conf/sqoop.properties 1371304 

Diff: https://reviews.apache.org/r/6498/diff/


Testing
-------

Only manual testing done.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-568: Configuration reload period should be configurable in PropertiesConfigurationProvider

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6498/#review10236
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Aug. 9, 2012, 7:11 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6498/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 7:11 p.m.)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Description
> -------
> 
> I've created new configuration option and propagate it to aConfigFilePoller thread.
> 
> 
> This addresses bug SQOOP-568.
>     https://issues.apache.org/jira/browse/SQOOP-568
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 1371304 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java 1371304 
>   /branches/sqoop2/dist/src/main/server/conf/sqoop.properties 1371304 
> 
> Diff: https://reviews.apache.org/r/6498/diff/
> 
> 
> Testing
> -------
> 
> Only manual testing done.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>