You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:46:45 UTC
[GitHub] [ignite] Vladsz83 opened a new pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Vladsz83 opened a new pull request #8424:
URL: https://github.com/apache/ignite/pull/8424
We should emphasize in the documentation that TcpDiscoverySpi prolongs detection of node failure if several IP addresses are set. Actual failure detection delay is: failureDetectionTimeout * addressesNumber + connRecoveryTimeout.
The problem is ability of node to run on several addresses. By default, all non-loop back addresses are assigned to node. Connection to a node is
established to one of its address. But if lost, other addresses are attempted to reconnect to sequentially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a change in pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on a change in pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#discussion_r526346857
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of `TcpDiscoverySpi`.
You can find the complete list of properties in the javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or `TcpDiscoverySpi.localAddress`.
Review comment:
Fixed with the exception we can bind only to one net. interface currently. Or automatically to all.
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of `TcpDiscoverySpi`.
You can find the complete list of properties in the javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or `TcpDiscoverySpi.localAddress`.
+By default, node obtains all available IP addresses. Several node addresses can prolong detection of node failure.
+You should not allow node bind to multiple ip addresses until they represent some real physical connections which can
+give you more reliability.
+====
+
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress`| Local host IP address used for discovery. | By default, the node uses the first non-loopback address it finds. If there is no non-loopback address available, then `java.net.InetAddress.getLocalHost()` is used.
+| `localAddress`| Local host IP address used for discovery. Prevails over `IgniteConfiguration.localHost`. | By default, all available addresses are assigned to node. If there is no non-loopback address available, then `java.net.InetAddress.getLocalHost()` is used.
Review comment:
Fixed.
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -111,7 +119,7 @@ You can find the list of all properties in the javadoc:org.apache.ignite.spi.com
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress` | The local address for the communication SPI to bind to. |
+| `localAddress` | The local address for the communication SPI to bind to. Prevails over `IgniteConfiguration.localHost`. |
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda commented on pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
dmagda commented on pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#issuecomment-728422124
@Vladsz83, should we encourage the developer to initialize the TcpCommunicationSpi.localAddresses as well? So that the nodes use only reachable network interfaces for communication needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda commented on a change in pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
dmagda commented on a change in pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#discussion_r524775114
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of `TcpDiscoverySpi`.
You can find the complete list of properties in the javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or `TcpDiscoverySpi.localAddress`.
Review comment:
Vlad,
Good explanation, crystal clear and straight to the point. I made some tweaks. Please use this final version below and see if we need to mention `TcpCommunicationSpi.localAddress` along with `TcpDiscoverySpi.localAddress`
_You should initialize the `IgniteConfiguration.localHost` or `TcpDiscoverySpi.localAddress` parameter only with those network interfaces that will be used for inter-node communication. By default, a node binds to and listens on all available IP addresses of an environment it's running on. It can prolong node failures detection if some of the node's addresses are not reachable from other cluster nodes._
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of `TcpDiscoverySpi`.
You can find the complete list of properties in the javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or `TcpDiscoverySpi.localAddress`.
+By default, node obtains all available IP addresses. Several node addresses can prolong detection of node failure.
+You should not allow node bind to multiple ip addresses until they represent some real physical connections which can
+give you more reliability.
+====
+
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress`| Local host IP address used for discovery. | By default, the node uses the first non-loopback address it finds. If there is no non-loopback address available, then `java.net.InetAddress.getLocalHost()` is used.
+| `localAddress`| Local host IP address used for discovery. Prevails over `IgniteConfiguration.localHost`. | By default, all available addresses are assigned to node. If there is no non-loopback address available, then `java.net.InetAddress.getLocalHost()` is used.
Review comment:
Please adjust to the following:
_... If set, overrides the `IgniteConfiguration.localHost` setting. | By default, a node binds to all available network addresses. If there is a non-loopback address available, then `java.net.InetAddress.getLocalHost()` is used._
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -111,7 +119,7 @@ You can find the list of all properties in the javadoc:org.apache.ignite.spi.com
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress` | The local address for the communication SPI to bind to. |
+| `localAddress` | The local address for the communication SPI to bind to. Prevails over `IgniteConfiguration.localHost`. |
Review comment:
Please update to:
_... If set, overrides `IgniteConfiguration.localHost` setting._
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 edited a comment on pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
Vladsz83 edited a comment on pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#issuecomment-729883264
> @Vladsz83, should we encourage the developer to initialize the TcpCommunicationSpi.localAddresses as well? So that the nodes use only reachable network interfaces for communication needs.
We should encourage user to set `IgniteConfiguration.localHost`. This one is read buy other components. ZooKeeperSpi as an example. No reason to setup localAddress everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#issuecomment-729883264
> @Vladsz83, should we encourage the developer to initialize the TcpCommunicationSpi.localAddresses as well? So that the nodes use only reachable network interfaces for communication needs.
We should encourage user to set `IgniteConfiguration.localHost`. This one is read buy other componentc. ZooKeeperSpi as an example. No reason to setup localAddress everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda commented on a change in pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
dmagda commented on a change in pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#discussion_r524777722
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -111,7 +119,7 @@ You can find the list of all properties in the javadoc:org.apache.ignite.spi.com
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress` | The local address for the communication SPI to bind to. |
+| `localAddress` | The local address for the communication SPI to bind to. Prevails over `IgniteConfiguration.localHost`. |
Review comment:
Please update to:
_... If set, overrides the `IgniteConfiguration.localHost` setting._
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda merged pull request #8424: IGNITE-13663 : Represent in the documenttion affection of several node addresses on failure detection v2.
Posted by GitBox <gi...@apache.org>.
dmagda merged pull request #8424:
URL: https://github.com/apache/ignite/pull/8424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org