[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606#discussion_r1008983363


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -534,6 +534,10 @@ private boolean processComplementData() {
             scheduleDate = complementListDate.get(0);
         } else if (processInstance.getState().typeIsFinished()) {
             endProcess();
+            // rerun process instance of complement didn't need create the next process complement
+            if (processInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
+                return true;
+            }

Review Comment:
   Discusstion in https://github.com/apache/dolphinscheduler/issues/12586#issuecomment-1296455628



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org