[GitHub] massakam opened a new pull request #3328: Some settings of WebSocket proxy are not effective

[GitBox <gi...@apache.org>]

massakam opened a new pull request #3328: Some settings of WebSocket proxy are not effective
URL: https://github.com/apache/pulsar/pull/3328
 
 
   ### Motivation
   
   There are `numIoThreads` and `connectionsPerBroker` in the WebSocket proxy settings, but even if specifying these values, the actual number of threads or connections does not change from the number of CPU cores.
   
   This is because the `WebSocketProxyConfiguration` object is converted to a `ServiceConfiguration` object and these settings can not be acquired. `numIoThreads` and `connectionsPerBroker` are not declared in the `ServiceConfiguration` class, but `webSocketNumIoThreads` and `webSocketConnectionsPerBroker` are declared.
   https://github.com/apache/pulsar/blob/2ccf7ff2a6c16f1b16342aa4529d5197195bad9d/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java#L86-L90
   https://github.com/apache/pulsar/blob/2ccf7ff2a6c16f1b16342aa4529d5197195bad9d/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/WebSocketService.java#L179-L185
   
   ### Modifications
   
   Renamed the fields of `WebSocketProxyConfiguration` as follows and made them match the field names of `ServiceConfiguration`.
   
   - numIoThreads -> webSocketNumIoThreads
   - connectionsPerBroker -> webSocketConnectionsPerBroker
   
   ### Result
   
   These settings become effective.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services