You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Jasha Joachimsthal (JIRA)" <ji...@apache.org> on 2012/06/29 22:43:44 UTC
[jira] [Created] (RAVE-711) Shared page is rendered before the user
accepts the page
Jasha Joachimsthal created RAVE-711:
---------------------------------------
Summary: Shared page is rendered before the user accepts the page
Key: RAVE-711
URL: https://issues.apache.org/jira/browse/RAVE-711
Project: Rave
Issue Type: Bug
Affects Versions: 0.12
Reporter: Jasha Joachimsthal
Canonical shares page with john.doe
john.doe clicks on shared page
Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-711) Shared page is rendered before the
user accepts the page
Posted by "Paul Sharples (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Sharples reassigned RAVE-711:
----------------------------------
Assignee: Paul Sharples (was: Daniel Gornstein)
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Paul Sharples
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch, fixPageRenderingBeforeAcceptingShare(Rave-711)-3.patch, fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-711) Shared page is rendered before the
user accepts the page
Posted by "Chris Geer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423135#comment-13423135 ]
Chris Geer commented on RAVE-711:
---------------------------------
Daniel,
Does that mean the shared page is still rendered (but hidden) before the accept? I would think that could still have side effects potentially. Ideally it would be nice to not even render the page at all prior to accept.
Chris
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-711) Shared page is rendered before the user
accepts the page
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-711:
----------------------------------
Attachment: fixPageRenderingBeforeAcceptingShare(Rave-711)-3.patch
Regarding Matt's comments, I moved the code back to the script block and preformed the logic to test if the page status is PENDING there.
This fix makes it so shared pages which are not yet accepted by the user, does not get rendered in the background.
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch, fixPageRenderingBeforeAcceptingShare(Rave-711)-3.patch, fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-711) Shared page is rendered before the
user accepts the page
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423152#comment-13423152 ]
Daniel Gornstein commented on RAVE-711:
---------------------------------------
Chris,
Yes that is what the fix is currently doing. I will try to make the page never render and submit a new patch.
The issue with this is, the check to see if the accept/decline box should pop up for the user viewing the shared page for the first time, doesn't happen until viewPage is called on that page.
Thanks,
Daniel Gornstein
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-711) Shared page is rendered before the
user accepts the page
Posted by "Paul Sharples (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448674#comment-13448674 ]
Paul Sharples commented on RAVE-711:
------------------------------------
I took the liberty to update Daniels patch (v3) and update it slightly so that instead of using dialog boxes, the "accept/decline" status is now rendered on the actual page itself. Originally my rationale for using the dialog box was so that a user could either click "accept" to accept the share, "decline" to refuse the share or "cancel", which would allow the page to be rendered and the user could see the page (but the next time they clicked on it, the dialog would once again appear). However, as a user can still click "remove share" in the page menu after they have previously clicked "accept", I dont think it makes any sense to use a dialog box now.
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Paul Sharples
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch, fixPageRenderingBeforeAcceptingShare(Rave-711)-3.patch, fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-711) Shared page is rendered before the user
accepts the page
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-711:
----------------------------------
Attachment: fixPageRenderingBeforeAcceptingShare(Rave-711).patch
For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-711) Shared page is rendered before the user
accepts the page
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-711:
----------------------------------
Attachment: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch
This is a second fix which does NOT render the content of the page at all instead of hiding and showing it.
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
> Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch, fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-711) Shared page is rendered before the
user accepts the page
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein reassigned RAVE-711:
-------------------------------------
Assignee: Daniel Gornstein
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
> Key: RAVE-711
> URL: https://issues.apache.org/jira/browse/RAVE-711
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.12
> Reporter: Jasha Joachimsthal
> Assignee: Daniel Gornstein
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira