You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/23 20:44:34 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #4215: Fix typos in code comments and Kconfig help texts.
hartmannathan opened a new pull request #4215:
URL: https://github.com/apache/incubator-nuttx/pull/4215
## Summary
STM32 (various families): Fix typos in code comments and Kconfig help texts.
## Impact
Improves readability. No functional changes.
## Testing
nxstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4215: Fix typos in code comments and Kconfig help texts.
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4215:
URL: https://github.com/apache/incubator-nuttx/pull/4215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4215: Fix typos in code comments and Kconfig help texts.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4215:
URL: https://github.com/apache/incubator-nuttx/pull/4215#discussion_r675931608
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -8244,7 +8244,7 @@ config STM32_ADC_MAX_SAMPLES
responsibility to correctly select this value.
Since the interfece to update the sampling time is available
Review comment:
```suggestion
Since the interface to update the sampling time is available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4215: Fix typos in code comments and Kconfig help texts.
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #4215:
URL: https://github.com/apache/incubator-nuttx/pull/4215#issuecomment-886215710
@saramonteiro @gustavonihei Good catches! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4215: Fix typos in code comments and Kconfig help texts.
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on a change in pull request #4215:
URL: https://github.com/apache/incubator-nuttx/pull/4215#discussion_r675895092
##########
File path: arch/arm/src/stm32l5/stm32l5_serial.c
##########
@@ -1795,9 +1795,9 @@ static int stm32l5serial_interrupt(int irq, FAR void *context, FAR void *arg)
* " " USART_ISR_ORE Overrun Error Detected
* USART_CR3_CTSIE USART_ISR_CTS CTS flag (not used)
*
- * NOTE: Some of these status bits must be cleared by explicity writing
- * one to the ICR register: USART_ICR_CTSCF, USART_ICR_LBDCF. Note of
- * those are currently being used.
+ * NOTE: Some of these status bits must be cleared by explicitly
+ * writing one to the ICR register: USART_ICR_CTSCF, USART_ICR_LBDCF.
+ * Note of those are currently being used.
Review comment:
```suggestion
* None of those are currently being used.
```
Shouldn't here be None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org