[jira] Commented: (SHINDIG-374) Proxy ignores e-tags / if-modified-since

["Emilio Daniel Gonzalez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609949#action_12609949 ] 

Emilio Daniel Gonzalez commented on SHINDIG-374:
------------------------------------------------

Hi, I resolved this bug.  Beside the ProxyHandler.php file. I had to change the RemoteContentRequest.php file. Is it correct to include that file in this patch? or, should I create another patch for fix the RemoteContentRequest.php file?

Cheers!

> Proxy ignores e-tags / if-modified-since
> ----------------------------------------
>
>                 Key: SHINDIG-374
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-374
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Chris Chabot
>
> The ProxyHandler class does it's own header control instead of using the generic Servlet one because it requires full control over what headers are send.
> However this currently means it doesn't honor if-modified-since and e-tag headers, which causes the proxied files to always be re-downloaded by the web browser.
> On straight get's it should really:
> - If if-modified-since is set, and the cached file time is within the refreshInterval params value, return not-modified
> - Create it's own e-tag's (md5(responseBody)), and if the e-tag's match return a not-modified

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.