You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/22 07:30:43 UTC

[GitHub] [pulsar] congbobo184 commented on a change in pull request #14781: [fix][txn]: fix pending ack is recovering throw CursorAlreadyClosedxception

congbobo184 commented on a change in pull request #14781:
URL: https://github.com/apache/pulsar/pull/14781#discussion_r831844989



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -398,7 +398,7 @@ public Entry get() {
         public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
             if (managedLedger.getConfig().isAutoSkipNonRecoverableData()
                     && exception instanceof ManagedLedgerException.NonRecoverableLedgerException
-                    || exception instanceof ManagedLedgerException.ManagedLedgerFencedException) {

Review comment:
       > Why remove the `ManagedLedgerFencedException` check?
   
   we can't delete ManagedLedgerFencedException, that's my mistake




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org