You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cmontemuino (via GitHub)" <gi...@apache.org> on 2023/09/06 10:35:54 UTC
[GitHub] [superset] cmontemuino opened a new pull request, #25200: docs: fix wrong type in PREFERRED_DATABASES example
cmontemuino opened a new pull request, #25200:
URL: https://github.com/apache/superset/pull/25200
### SUMMARY
The example is using `List` as type, but it is not being imported in `config.py`. Thus, if you follow the example, an error will happen during runtime.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Not applicable. This is doc related.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke merged pull request #25200: docs: fix wrong type in PREFERRED_DATABASES example
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #25200:
URL: https://github.com/apache/superset/pull/25200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #25200: docs: fix wrong type in PREFERRED_DATABASES example
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #25200:
URL: https://github.com/apache/superset/pull/25200#issuecomment-1708455878
I dug around and see that `List` was no longer imported in config.py as of https://github.com/apache/superset/pull/24197, but the docs weren't updated. Good catch, thanks!
Let's merge this. But in general I wonder if we should just link to relevant sections of config.py in cases like this, rather than duplicating code which leaves one more thing to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org