[GitHub] [ozone] JyotinderSingh commented on a change in pull request #3083: HDDS-5904. Update Recon for files created with FSO Buckets.

[GitBox <gi...@apache.org>]

JyotinderSingh commented on a change in pull request #3083:
URL: https://github.com/apache/ozone/pull/3083#discussion_r805755825



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java
##########
@@ -157,11 +159,29 @@ public Response getKeysForContainer(
       for (ContainerKeyPrefix containerKeyPrefix : containerKeyPrefixMap
           .keySet()) {
 
-        // Directly calling get() on the Key table instead of iterating since
-        // only full keys are supported now. When we change to using a prefix
-        // of the key, this needs to change to prefix seek.
-        OmKeyInfo omKeyInfo = omMetadataManager.getKeyTable(getBucketLayout())
-            .getSkipCache(containerKeyPrefix.getKeyPrefix());
+        OmKeyInfo omKeyInfo = null;
+
+        for (BucketLayout bucketLayout : getBucketLayoutList()) {

Review comment:
       I am not sure if iterating through the bucket layouts is the best idea, I am open to other approaches as well if any.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org