You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Hay (JIRA)" <ji...@apache.org> on 2010/11/16 23:31:14 UTC

[jira] Created: (FELIX-2699) Disable writing configuration back to .cfg files

Disable writing configuration back to .cfg files
------------------------------------------------

                 Key: FELIX-2699
                 URL: https://issues.apache.org/jira/browse/FELIX-2699
             Project: Felix
          Issue Type: Improvement
          Components: File Install
    Affects Versions: fileinstall-3.1.0
            Reporter: David Hay


I'd like to see an option that indicates whether changes to a Configuration should prompt writing a .cfg file again.

The problem with rewriting the .cfg file is that I lose any placeholders I may have originally had.  So a config value like this:

my.config=${some.placeholder}

gets overwritten with 

my.config=actual.value



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2699) Disable writing configuration back to .cfg files

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965328#action_12965328 ] 

Guillaume Nodet commented on FELIX-2699:
----------------------------------------

I'll implement that, but due to the fact that the ConfigInstaller is a global object, the flag will be global too and will be configured on the bundle properties.

> Disable writing configuration back to .cfg files
> ------------------------------------------------
>
>                 Key: FELIX-2699
>                 URL: https://issues.apache.org/jira/browse/FELIX-2699
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-3.1.0
>            Reporter: David Hay
>
> I'd like to see an option that indicates whether changes to a Configuration should prompt writing a .cfg file again.
> The problem with rewriting the .cfg file is that I lose any placeholders I may have originally had.  So a config value like this:
> my.config=${some.placeholder}
> gets overwritten with 
> my.config=actual.value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2699) Disable writing configuration back to .cfg files

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-2699.
------------------------------------

       Resolution: Fixed
    Fix Version/s: fileinstall-3.1.2
         Assignee: Guillaume Nodet

Committing to https://svn.apache.org/repos/asf/felix/trunk ...
	M	fileinstall/src/main/java/org/apache/felix/fileinstall/internal/ConfigInstaller.java
	M	fileinstall/src/main/java/org/apache/felix/fileinstall/internal/DirectoryWatcher.java
Committed r1040674


> Disable writing configuration back to .cfg files
> ------------------------------------------------
>
>                 Key: FELIX-2699
>                 URL: https://issues.apache.org/jira/browse/FELIX-2699
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-3.1.0
>            Reporter: David Hay
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-3.1.2
>
>
> I'd like to see an option that indicates whether changes to a Configuration should prompt writing a .cfg file again.
> The problem with rewriting the .cfg file is that I lose any placeholders I may have originally had.  So a config value like this:
> my.config=${some.placeholder}
> gets overwritten with 
> my.config=actual.value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2699) Disable writing configuration back to .cfg files

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965320#action_12965320 ] 

Guillaume Nodet commented on FELIX-2699:
----------------------------------------

Not sure how you modify the configuration but fileinstall compares the processed values before writing it, so if you use system properties, they should not be overriden, as the computed values would be the same.

Anyway, having a way to disable this behavior looks like a good idea anyway.

> Disable writing configuration back to .cfg files
> ------------------------------------------------
>
>                 Key: FELIX-2699
>                 URL: https://issues.apache.org/jira/browse/FELIX-2699
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-3.1.0
>            Reporter: David Hay
>
> I'd like to see an option that indicates whether changes to a Configuration should prompt writing a .cfg file again.
> The problem with rewriting the .cfg file is that I lose any placeholders I may have originally had.  So a config value like this:
> my.config=${some.placeholder}
> gets overwritten with 
> my.config=actual.value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.