You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/28 16:01:26 UTC

[GitHub] [incubator-inlong] yunqingmoswu opened a new pull request #3410: [INLONG-3405][Manager] Support generic partition configuration for Hive sink

yunqingmoswu opened a new pull request #3410:
URL: https://github.com/apache/incubator-inlong/pull/3410


   ### Title Name: [INLONG-3405][Manager] Support generic partition configuration for Hive sink
   
   Fixes #3405 
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #3410: [INLONG-3405][Manager] Support generic partition configuration for Hive sink

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #3410:
URL: https://github.com/apache/incubator-inlong/pull/3410


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #3410: [INLONG-3405][Manager] Support generic partition configuration for Hive sink

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3410:
URL: https://github.com/apache/incubator-inlong/pull/3410#discussion_r837062359



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/SinkPartitionFieldInfo.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sink;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+/**
+ * Sink partition field info
+ */
+@Data
+@ApiModel("Sink partition field info")
+public class SinkPartitionFieldInfo {

Review comment:
       It is recommended to move it to `pojo/sink/hive` package and name it `HivePartitionField`.

##########
File path: inlong-manager/manager-web/sql/apache_inlong_manager.sql
##########
@@ -16,13 +16,16 @@
  */
 
 SET NAMES utf8mb4;
-SET FOREIGN_KEY_CHECKS = 0;

Review comment:
       Please do not format this file.

##########
File path: inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkFieldEntityMapper.xml
##########
@@ -46,8 +46,7 @@
         insert into stream_sink_field (id, inlong_group_id, inlong_stream_id,
                                        sink_id, sink_type, field_name,
                                        field_type, field_comment, source_field_name,
-                                       source_field_type, is_meta_field, field_format,

Review comment:
       Do not change the format.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3410: [INLONG-3405][Manager] Support generic partition configuration for Hive sink

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on a change in pull request #3410:
URL: https://github.com/apache/incubator-inlong/pull/3410#discussion_r837074233



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/SinkPartitionFieldInfo.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sink;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+/**
+ * Sink partition field info
+ */
+@Data
+@ApiModel("Sink partition field info")
+public class SinkPartitionFieldInfo {

Review comment:
       done

##########
File path: inlong-manager/manager-web/sql/apache_inlong_manager.sql
##########
@@ -16,13 +16,16 @@
  */
 
 SET NAMES utf8mb4;
-SET FOREIGN_KEY_CHECKS = 0;

Review comment:
       done

##########
File path: inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkFieldEntityMapper.xml
##########
@@ -46,8 +46,7 @@
         insert into stream_sink_field (id, inlong_group_id, inlong_stream_id,
                                        sink_id, sink_type, field_name,
                                        field_type, field_comment, source_field_name,
-                                       source_field_type, is_meta_field, field_format,

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org