You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/12/03 18:44:09 UTC
Review Request 40923: Log displays wrong text for various tasks of
Express Upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40923/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-14190
https://issues.apache.org/jira/browse/AMBARI-14190
Repository: ambari
Description
-------
Performed an Express Upgrade from 2.2.8 to 2.3.4
It was observed that at multiple stages during EU, we print text as "Rolling Upgrade" instead of "Express Upgrade"
Few examples where stdout shows as "Rolling Upgrade":
"command_detail" : "Check Tez Tarball",
This is a Rolling Upgrade, but keep the version unchanged
"command_detail" : "Prepare HDFS"
PREPARE rolling upgrade
"command_detail" : "RESTART MAPREDUCE2/HISTORYSERVER",
Because this is a Rolling Upgrade, will use version
"command_detail" : "RESTART HIVE/HIVE_SERVER",
Because this is a Rolling Upgrade, will use version
"command_detail" : "Execute HDFS Finalize",
Executing Rolling Upgrade finalize
For a complete list, check api output
---------
Looked through code, changed to something like "Stack upgrade" where relevant
Also fixed agent unit test failures when executed from the IDE
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py a066d08
ambari-agent/src/test/python/resource_management/TestPackageResource.py 5868108
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 4f77552
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py d442852
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 8fe1499
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java c3dae85
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e3a7f65
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 02a5a1a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 60210c3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 5bbc201
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 65149a3
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 35e3cd4
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py b9d37a6
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 8c53a4b
Diff: https://reviews.apache.org/r/40923/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 40923: Log displays wrong text for various tasks of
Express Upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40923/#review108857
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 3, 2015, 5:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40923/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 5:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14190
> https://issues.apache.org/jira/browse/AMBARI-14190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performed an Express Upgrade from 2.2.8 to 2.3.4
>
> It was observed that at multiple stages during EU, we print text as "Rolling Upgrade" instead of "Express Upgrade"
>
> Few examples where stdout shows as "Rolling Upgrade":
>
> "command_detail" : "Check Tez Tarball",
> This is a Rolling Upgrade, but keep the version unchanged
>
> "command_detail" : "Prepare HDFS"
> PREPARE rolling upgrade
>
> "command_detail" : "RESTART MAPREDUCE2/HISTORYSERVER",
> Because this is a Rolling Upgrade, will use version
>
> "command_detail" : "RESTART HIVE/HIVE_SERVER",
> Because this is a Rolling Upgrade, will use version
>
> "command_detail" : "Execute HDFS Finalize",
> Executing Rolling Upgrade finalize
>
> For a complete list, check api output
>
> ---------
> Looked through code, changed to something like "Stack upgrade" where relevant
>
> Also fixed agent unit test failures when executed from the IDE
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py a066d08
> ambari-agent/src/test/python/resource_management/TestPackageResource.py 5868108
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 4f77552
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py d442852
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 8fe1499
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java c3dae85
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e3a7f65
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 02a5a1a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 60210c3
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 5bbc201
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 65149a3
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 35e3cd4
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py b9d37a6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 8c53a4b
>
> Diff: https://reviews.apache.org/r/40923/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 40923: Log displays wrong text for various tasks of
Express Upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40923/#review108850
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 3, 2015, 12:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40923/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 12:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14190
> https://issues.apache.org/jira/browse/AMBARI-14190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Performed an Express Upgrade from 2.2.8 to 2.3.4
>
> It was observed that at multiple stages during EU, we print text as "Rolling Upgrade" instead of "Express Upgrade"
>
> Few examples where stdout shows as "Rolling Upgrade":
>
> "command_detail" : "Check Tez Tarball",
> This is a Rolling Upgrade, but keep the version unchanged
>
> "command_detail" : "Prepare HDFS"
> PREPARE rolling upgrade
>
> "command_detail" : "RESTART MAPREDUCE2/HISTORYSERVER",
> Because this is a Rolling Upgrade, will use version
>
> "command_detail" : "RESTART HIVE/HIVE_SERVER",
> Because this is a Rolling Upgrade, will use version
>
> "command_detail" : "Execute HDFS Finalize",
> Executing Rolling Upgrade finalize
>
> For a complete list, check api output
>
> ---------
> Looked through code, changed to something like "Stack upgrade" where relevant
>
> Also fixed agent unit test failures when executed from the IDE
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py a066d08
> ambari-agent/src/test/python/resource_management/TestPackageResource.py 5868108
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 4f77552
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py d442852
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 8fe1499
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java c3dae85
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e3a7f65
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 02a5a1a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 60210c3
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 5bbc201
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 65149a3
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 35e3cd4
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py b9d37a6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 8c53a4b
>
> Diff: https://reviews.apache.org/r/40923/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>