You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2004/08/20 20:04:17 UTC
Re: [Issue 2012] New - file:///c%3a/... no longer works on 1.1.0 RC 2
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> > Testing 1.1.0 RC2 I see that this is no longer the case. I'd
> > really appricate it if this could be fixed for the final release,
> > since otherwise it'll break WebSVN.
> >
> This was broken when I fixed the get_repos_root problem (it being
> URI-decoded). I don't think it was documented to be allowed to URI-encode
> the colon. Depends on whether you interpret it as a separator or not. It
> complicates things a little to support this.
I'm not sure I understand what part of your change broke this. Can
you elaborate on what you think went wrong here?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Issue 2012] New - file:///c%3a/... no longer works on 1.1.0 RC
2
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Fri, 20 Aug 2004, C. Michael Pilato wrote:
> "Peter N. Lundblad" <pe...@famlundblad.se> writes:
>
> > > Testing 1.1.0 RC2 I see that this is no longer the case. I'd
> > > really appricate it if this could be fixed for the final release,
> > > since otherwise it'll break WebSVN.
> > >
> > This was broken when I fixed the get_repos_root problem (it being
> > URI-decoded). I don't think it was documented to be allowed to URI-encode
> > the colon. Depends on whether you interpret it as a separator or not. It
> > complicates things a little to support this.
>
> I'm not sure I understand what part of your change broke this. Can
> you elaborate on what you think went wrong here?
>
Check svn_ra_local__split_URL in the part conditionalized for Windows. It
checks for drive: before URI-decoding the path. The problem is that if we
URI-decode before, there is no way to say X| as the first two characters
in a path. I still wonder if URI-encoded : should be interpreted as colon.
IN that case we have to special-case the |.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org