You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Branimir Lambov (JIRA)" <ui...@incubator.apache.org> on 2009/06/02 15:45:09 UTC

[jira] Created: (UIMA-1365) Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working

Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working
-------------------------------------------------------------------------------------------------------------------

                 Key: UIMA-1365
                 URL: https://issues.apache.org/jira/browse/UIMA-1365
             Project: UIMA
          Issue Type: Bug
          Components: Core Java Framework
            Reporter: Branimir Lambov
            Priority: Minor


FSIndexRepositoryImpl contains pieces of code that are meant to ensure forward and reverse iterators are inverses of each other by doing additional comparison by FS address to resolve equality. However, this is not fully implemented and isn't working properly.

The iteratorComparator defined by the PointerIterator class is not used for sorting elements in moveToNext() and moveToPrevious(), where the default comparators for the iterators are used instead. For the typical use of PointerIterator of listing the annotation index this does not cause a problem as the type priorities ensure ordering between indexes of different types, while the ordering is always defined within the individual indexes.

The piece of code implementing the extra comparison should either be removed or corrected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (UIMA-1365) Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working

Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor updated UIMA-1365:
---------------------------------

    Fix Version/s: 2.3

> Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: UIMA-1365
>                 URL: https://issues.apache.org/jira/browse/UIMA-1365
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Branimir Lambov
>            Priority: Minor
>             Fix For: 2.3
>
>
> FSIndexRepositoryImpl contains pieces of code that are meant to ensure forward and reverse iterators are inverses of each other by doing additional comparison by FS address to resolve equality. However, this is not fully implemented and isn't working properly.
> The iteratorComparator defined by the PointerIterator class is not used for sorting elements in moveToNext() and moveToPrevious(), where the default comparators for the iterators are used instead. For the typical use of PointerIterator of listing the annotation index this does not cause a problem as the type priorities ensure ordering between indexes of different types, while the ordering is always defined within the individual indexes.
> The piece of code implementing the extra comparison should either be removed or corrected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (UIMA-1365) Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working

Posted by "Branimir Lambov (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Branimir Lambov closed UIMA-1365.
---------------------------------

    Resolution: Fixed

Fixed as part of UIMA-1366.

> Code trying to ensure reverse iterators list items in the opposite order of forward ones is present but not working
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: UIMA-1365
>                 URL: https://issues.apache.org/jira/browse/UIMA-1365
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Branimir Lambov
>            Priority: Minor
>
> FSIndexRepositoryImpl contains pieces of code that are meant to ensure forward and reverse iterators are inverses of each other by doing additional comparison by FS address to resolve equality. However, this is not fully implemented and isn't working properly.
> The iteratorComparator defined by the PointerIterator class is not used for sorting elements in moveToNext() and moveToPrevious(), where the default comparators for the iterators are used instead. For the typical use of PointerIterator of listing the annotation index this does not cause a problem as the type priorities ensure ordering between indexes of different types, while the ordering is always defined within the individual indexes.
> The piece of code implementing the extra comparison should either be removed or corrected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.