You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/10 05:56:50 UTC

[GitHub] jtulach commented on a change in pull request #715: WIP: Download nbjavac when turning on support for Java

jtulach commented on a change in pull request #715: WIP: Download nbjavac when turning on support for Java
URL: https://github.com/apache/incubator-netbeans/pull/715#discussion_r216204833
 
 

 ##########
 File path: autoupdate.services/src/org/netbeans/api/autoupdate/InstallSupport.java
 ##########
 @@ -120,7 +120,7 @@ public Installer doValidate(Validator validator, ProgressHandle progress/*or nul
      * @see #doValidate
      */
     public Restarter doInstall(Installer installer ,ProgressHandle progress/*or null*/) throws OperationException {
-        Boolean restart = impl.doInstall (installer, progress, false);
 
 Review comment:
   The change was made to make the PR functional. In the PR overview there is a note:
   
   * module isn't installed immediately after download - workarounded as 8956f83
       * future version of the NBM shouldn't require restart
   
   E.g. this actual change should not get merged at the end. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists