You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2016/02/26 13:11:08 UTC
AjaxFallbackOrderByLink is not really Fallback
Hi,
org.apache.wicket.extensions.ajax.markup.html.repeater.data.sort.AjaxFallbackOrderByLink
<https://github.com/apache/wicket/blob/ae36388c00654b7260dde9782f4f1153447901e3/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByLink.java>
is
not really a fallback link as the others.
It never passes "null" as a AjaxRequestTarget to its #onClick().
Its name should really be AjaxOrderByLink.
I'm going to introduce AjaxOrderByLink with the current code and change
AFOBL to extend idt, and deprecate AFOBL in Wicket 8.x.
Please let me know if you disagree!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
Re: AjaxFallbackOrderByLink is not really Fallback
Posted by Sven Meier <sv...@meiers.net>.
The changes look just fine.
Thanks
Sven
On 26.02.2016 14:23, Martin Grigorov wrote:
> I've introduced Optional for AjaxFallback** components with
> https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=commit;h=ec1db0f3
> Transitively I've had to modify also AjaxTabbedPanel, RatingPanel and
> Tree/TableTree (#updateNode()). Until now those were AjaxFallback** under
> cover, and they didn't care about target being null.
>
> @Sven: please review the Tree related classes. The reason for the change is
> the usage of StyledLinkLabel. Please revert the changes in that area if
> this is not desired.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Feb 26, 2016 at 2:12 PM, Martijn Dashorst <
> martijn.dashorst@gmail.com> wrote:
>
>> I don't see a problem with your solution. Go for it.
>>
>> Martijn
>>
>>
>> On Fri, Feb 26, 2016 at 1:11 PM, Martin Grigorov <mg...@apache.org>
>> wrote:
>>> Hi,
>>>
>>>
>> org.apache.wicket.extensions.ajax.markup.html.repeater.data.sort.AjaxFallbackOrderByLink
>>> <
>> https://github.com/apache/wicket/blob/ae36388c00654b7260dde9782f4f1153447901e3/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByLink.java
>>> is
>>> not really a fallback link as the others.
>>> It never passes "null" as a AjaxRequestTarget to its #onClick().
>>> Its name should really be AjaxOrderByLink.
>>>
>>> I'm going to introduce AjaxOrderByLink with the current code and change
>>> AFOBL to extend idt, and deprecate AFOBL in Wicket 8.x.
>>>
>>> Please let me know if you disagree!
>>>
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>
>>
>> --
>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>
Re: AjaxFallbackOrderByLink is not really Fallback
Posted by Martin Grigorov <mg...@apache.org>.
I've introduced Optional for AjaxFallback** components with
https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=commit;h=ec1db0f3
Transitively I've had to modify also AjaxTabbedPanel, RatingPanel and
Tree/TableTree (#updateNode()). Until now those were AjaxFallback** under
cover, and they didn't care about target being null.
@Sven: please review the Tree related classes. The reason for the change is
the usage of StyledLinkLabel. Please revert the changes in that area if
this is not desired.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Fri, Feb 26, 2016 at 2:12 PM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> I don't see a problem with your solution. Go for it.
>
> Martijn
>
>
> On Fri, Feb 26, 2016 at 1:11 PM, Martin Grigorov <mg...@apache.org>
> wrote:
> > Hi,
> >
> >
> org.apache.wicket.extensions.ajax.markup.html.repeater.data.sort.AjaxFallbackOrderByLink
> > <
> https://github.com/apache/wicket/blob/ae36388c00654b7260dde9782f4f1153447901e3/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByLink.java
> >
> > is
> > not really a fallback link as the others.
> > It never passes "null" as a AjaxRequestTarget to its #onClick().
> > Its name should really be AjaxOrderByLink.
> >
> > I'm going to introduce AjaxOrderByLink with the current code and change
> > AFOBL to extend idt, and deprecate AFOBL in Wicket 8.x.
> >
> > Please let me know if you disagree!
> >
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>
Re: AjaxFallbackOrderByLink is not really Fallback
Posted by Martijn Dashorst <ma...@gmail.com>.
I don't see a problem with your solution. Go for it.
Martijn
On Fri, Feb 26, 2016 at 1:11 PM, Martin Grigorov <mg...@apache.org> wrote:
> Hi,
>
> org.apache.wicket.extensions.ajax.markup.html.repeater.data.sort.AjaxFallbackOrderByLink
> <https://github.com/apache/wicket/blob/ae36388c00654b7260dde9782f4f1153447901e3/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByLink.java>
> is
> not really a fallback link as the others.
> It never passes "null" as a AjaxRequestTarget to its #onClick().
> Its name should really be AjaxOrderByLink.
>
> I'm going to introduce AjaxOrderByLink with the current code and change
> AFOBL to extend idt, and deprecate AFOBL in Wicket 8.x.
>
> Please let me know if you disagree!
>
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
--
Become a Wicket expert, learn from the best: http://wicketinaction.com