You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Burwell <jb...@basho.com> on 2012/12/18 19:10:58 UTC

Review Request: [CLOUDSTACK-660] Fixes traffic label configuration in Marvin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8669/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Marvin failed to properly configure network traffic labels due to an improper check none on the labeldict.  This patch correct this issue, and corrects a logical swap of the Xen and KVM traffic labels.


This addresses bug CLOUDSTACK-660.


Diffs
-----

  tools/marvin/marvin/deployDataCenter.py 01235fe 

Diff: https://reviews.apache.org/r/8669/diff/


Testing
-------


Thanks,

John Burwell


Re: Review Request: [CLOUDSTACK-660] Fixes traffic label configuration in Marvin

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8669/#review14662
-----------------------------------------------------------

Ship it!


Looks good.  Applied to master.

- Chip Childers


On Dec. 18, 2012, 6:10 p.m., John Burwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8669/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 6:10 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Marvin failed to properly configure network traffic labels due to an improper check none on the labeldict.  This patch correct this issue, and corrects a logical swap of the Xen and KVM traffic labels.
> 
> 
> This addresses bug CLOUDSTACK-660.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py 01235fe 
> 
> Diff: https://reviews.apache.org/r/8669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Burwell
> 
>