You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 11:43:47 UTC

[GitHub] [airflow] potiuk opened a new pull request #19512: Optimizes running tests for public GitHub Runners.

potiuk opened a new pull request #19512:
URL: https://github.com/apache/airflow/pull/19512

We started to get more (and almost consistent) OOM failures when
we tried to run all tests in parallel for the public GitHub
runners. This could previously happen for Providers and Integration
tests but it started to happen for Core tests.

This PR optimizes this to also make Core tests sequentially run
and refactors the code to make it much more readable and easy to
understand what's going on there.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19512: Optimizes running tests for public GitHub Runners.

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19512:
URL: https://github.com/apache/airflow/pull/19512#issuecomment-965094571


   Looks like it's going to be much more stable for "regular" PRs. Let's merge it quickly :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #19512: Optimizes running tests for public GitHub Runners.

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #19512:
URL: https://github.com/apache/airflow/pull/19512#issuecomment-965126030


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19512: Optimizes running tests for public GitHub Runners.

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19512:
URL: https://github.com/apache/airflow/pull/19512#issuecomment-965163474


   There are still occasional failures: https://github.com/apache/airflow/runs/4165358689?check_suite_focus=true - but they are much less frequent. This was a Core test running on it's own and likely we might want to make some optimisation and find the culprit separately. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19512: Optimizes running tests for public GitHub Runners.

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19512:
URL: https://github.com/apache/airflow/pull/19512#issuecomment-965054385






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #19512: Optimizes running tests for public GitHub Runners.

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #19512:
URL: https://github.com/apache/airflow/pull/19512


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org