[GitHub] [pinot] richardstartin commented on a change in pull request #8102: lock free DimensionDataTableManager

[GitBox <gi...@apache.org>]

richardstartin commented on a change in pull request #8102:
URL: https://github.com/apache/pinot/pull/8102#discussion_r796915319



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##########
@@ -75,16 +72,10 @@ public static DimensionTableDataManager getInstanceByTableName(String tableNameW
     return INSTANCES.get(tableNameWithType);
   }
 
-  /**
-   * Instance properties/methods
-   */
-  private final ReadWriteLock _rwl = new ReentrantReadWriteLock();
-  private final Lock _lookupTableReadLock = _rwl.readLock();
-  private final Lock _lookupTableWriteLock = _rwl.writeLock();
-
-  // _lookupTable is a HashMap used for storing/serving records for a table keyed by table PK
-  @GuardedBy("_rwl")
-  private final Map<PrimaryKey, GenericRow> _lookupTable = new HashMap<>();
+  @SuppressWarnings("rawtypes")
+  private static final AtomicReferenceFieldUpdater<DimensionTableDataManager, Map> UPDATER =

Review comment:
       Yes, for the CAS




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org