You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/06/27 18:34:33 UTC
Review Request 12134: removed txn attribute from DB annotation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
- All of this references to txn removed
- Attribute removed from annotation
- Documentation references removed
Diffs
-----
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 8f7826f
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 3c34023
engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 810b973
engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 45a8068
engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java c55cf28
engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java fac35a9
engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a8cb2b3
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java f82b511
engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 2a3b469
server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
utils/src/com/cloud/utils/db/DB.java f83a7ea
utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700
Diff: https://reviews.apache.org/r/12134/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/#review25889
-----------------------------------------------------------
Ship it!
Ship It: Not committed, Pending review from alexh
- Darren Shepherd
On Sept. 4, 2013, 4:55 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12134/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 4:55 p.m.)
>
>
> Review request for cloudstack, Alex Huang and Darren Shepherd.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
> - All of this references to txn removed
> - Attribute removed from annotation
> - Documentation references removed
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 5ba65cc
> engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
> engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
> engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
> engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
> engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
> engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java d3a2409
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
> engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 41ee7a7
> engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
> engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
> engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 41f911c
> engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java 0f83815
> engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
> engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
> engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
> engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
> engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
> engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
> engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
> engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java 518237d
> engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java 13c37c4
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
> engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
> engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
> engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
> engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java bf28410
> engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
> engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
> engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b39f844
> framework/db/src/com/cloud/utils/db/DB.java f83a7ea
> framework/db/src/com/cloud/utils/db/GenericDaoBase.java 94e5374
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
> plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
> plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
> server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 266e65f
> server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
> server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
> server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
> server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
> server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
> server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
> server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
> server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
> server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
>
> Diff: https://reviews.apache.org/r/12134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/#review26678
-----------------------------------------------------------
Ship it!
master: bd8536739c012e1025d35271ce82dbc9e5e66a8d
- Darren Shepherd
On Sept. 4, 2013, 4:55 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12134/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 4:55 p.m.)
>
>
> Review request for cloudstack, Alex Huang and Darren Shepherd.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
> - All of this references to txn removed
> - Attribute removed from annotation
> - Documentation references removed
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 5ba65cc
> engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
> engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
> engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
> engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
> engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
> engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java d3a2409
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
> engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 41ee7a7
> engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
> engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
> engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 41f911c
> engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java 0f83815
> engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
> engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
> engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
> engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
> engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
> engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
> engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
> engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java 518237d
> engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java 13c37c4
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
> engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
> engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
> engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
> engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java bf28410
> engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
> engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
> engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b39f844
> framework/db/src/com/cloud/utils/db/DB.java f83a7ea
> framework/db/src/com/cloud/utils/db/GenericDaoBase.java 94e5374
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
> plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
> plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
> server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 266e65f
> server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
> server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
> server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
> server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
> server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
> server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
> server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
> server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
> server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
>
> Diff: https://reviews.apache.org/r/12134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/#review25888
-----------------------------------------------------------
Ship it!
Ship It!
- Darren Shepherd
On Sept. 4, 2013, 4:55 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12134/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 4:55 p.m.)
>
>
> Review request for cloudstack, Alex Huang and Darren Shepherd.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
> - All of this references to txn removed
> - Attribute removed from annotation
> - Documentation references removed
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 5ba65cc
> engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
> engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
> engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
> engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
> engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
> engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java d3a2409
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
> engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 41ee7a7
> engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
> engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
> engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 41f911c
> engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java 0f83815
> engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
> engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
> engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
> engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
> engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
> engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
> engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
> engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java 518237d
> engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java 13c37c4
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
> engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
> engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
> engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
> engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java bf28410
> engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
> engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
> engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b39f844
> framework/db/src/com/cloud/utils/db/DB.java f83a7ea
> framework/db/src/com/cloud/utils/db/GenericDaoBase.java 94e5374
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
> plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
> plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
> server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 266e65f
> server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
> server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
> server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
> server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
> server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
> server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
> server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
> server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
> server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
>
> Diff: https://reviews.apache.org/r/12134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Kelven Yang <ke...@citrix.com>.
On 9/4/13 10:18 AM, "Darren Shepherd" <da...@gmail.com> wrote:
>On 09/04/2013 10:04 AM, Alex Huang wrote:
>> Kelven and Darren should review this.
>>
>> That attribute used to be always read to determine if a method should
>>be intercepted at load time. My understanding is the switch to using
>>spring as the injection mechanism caused this to be turned off and now
>>every single method is intercepted, which is terrible. I don¹t know if
>>Kelven and/or Darren has any plans to fix this. If they don¹t plan on
>>fixing it, then we should just commit it.
>>
>
>Alex,
>
>My plan is to essentially remove the existence of @DB. I'm working on
>that now.
+1 for removing @DB. The approach to mimic all the semantics in Spring for
@DB that I did last time was due to the time constraint I had. I tried to
minimized the code changes, therefore mimic @DB semantics is the cheapest
strategy.
Giving for what @DB is doing, it merely just helps developer to do a per
call-chain context open/close automatically, And open transaction context
is a very cheap operation which can be done by just doing it at
entry-point of the very top of the call chain. I should have done that
last time.
-Kelven
> In the meantime I think its good to just remove the txn
>attribute as the patch does. I clicked "ship it", but deferred to you
>to commit.
>
>Darren
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Darren Shepherd <da...@gmail.com>.
On 09/04/2013 10:04 AM, Alex Huang wrote:
> Kelven and Darren should review this.
>
> That attribute used to be always read to determine if a method should be intercepted at load time. My understanding is the switch to using spring as the injection mechanism caused this to be turned off and now every single method is intercepted, which is terrible. I don’t know if Kelven and/or Darren has any plans to fix this. If they don’t plan on fixing it, then we should just commit it.
>
Alex,
My plan is to essentially remove the existence of @DB. I'm working on
that now. In the meantime I think its good to just remove the txn
attribute as the patch does. I clicked "ship it", but deferred to you
to commit.
Darren
RE: Review Request 12134: removed txn attribute from DB annotation
Posted by Alex Huang <Al...@citrix.com>.
Resending this with the appropriate email for Darren.
--Alex
> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Wednesday, September 4, 2013 10:05 AM
> To: Prasanna Santhanam; Darren Shepherd
> Cc: Laszlo Hornyak; cloudstack; Kelven Yang
> Subject: RE: Review Request 12134: removed txn attribute from DB
> annotation
>
> Kelven and Darren should review this.
>
> That attribute used to be always read to determine if a method should be
> intercepted at load time. My understanding is the switch to using spring as
> the injection mechanism caused this to be turned off and now every single
> method is intercepted, which is terrible. I don’t know if Kelven and/or
> Darren has any plans to fix this. If they don’t plan on fixing it, then we should
> just commit it.
>
> --Alex
>
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Wednesday, September 4, 2013 9:56 AM
> To: Darren Shepherd; Alex Huang
> Cc: Prasanna Santhanam; Laszlo Hornyak; cloudstack
> Subject: Re: Review Request 12134: removed txn attribute from DB
> annotation
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12134/
>
>
> Review request for cloudstack, Alex Huang and Darren Shepherd.
> By Laszlo Hornyak.
>
> Updated Sept. 4, 2013, 4:55 p.m.
>
> Changes
>
> including couple reviewers
>
> Repository: cloudstack-git
> Description
>
> The txn attribute was used often with the DB annotation, but it does not
> have an effect on the behavior of the code since it is never read.
>
> - All of this references to txn removed
>
> - Attribute removed from annotation
>
> - Documentation references removed
>
>
> Diffs
>
> *
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/
> api/db/dao/EngineHostDaoImpl.java (5ba65cc)
> * engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java
> (f071cea)
> *
> engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoIm
> pl.java (cff4cfc)
> * engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java
> (b12fa9d)
> *
> engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java
> (353402d)
> *
> engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoIm
> pl.java (b52e373)
> * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
> (d3a2409)
> *
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.j
> ava (782ee0d)
> *
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.jav
> a (d732e6f)
> * engine/schema/src/com/cloud/host/dao/HostDaoImpl.java (41ee7a7)
> *
> engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoIm
> pl.java (e7a7b34)
> *
> engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImp
> l.java (01f8861)
> *
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDa
> oImpl.java (ea6437d)
> * engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java
> (41f911c)
> * engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java
> (0f83815)
> *
> engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java
> (bbb9203)
> *
> engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoI
> mpl.java (b176760)
> *
> engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancer
> DaoImpl.java (c29c164)
> *
> engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.j
> ava (3cdd738)
> *
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java
> (1e26a51)
> *
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProvid
> erDaoImpl.java (16a23dd)
> *
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDa
> oImpl.java (7e47239)
> * engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java
> (61fe52a)
> *
> engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl
> .java (dba835f)
> * engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java
> (fe435c0)
> *
> engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java
> (518237d)
> * engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java
> (6560b90)
> *
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java
> (13c37c4)
> *
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java
> (2cda547)
> *
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapD
> aoImpl.java (4b5f1b9)
> *
> engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.ja
> va (a992181)
> *
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java
> (ef8237a)
> *
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMap
> DaoImpl.java (7282443)
> *
> engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java
> (14b2abf)
> *
> engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java
> (052bae4)
> * engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java
> (bf28410)
> * engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java
> (7c5c9cc)
> *
> engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java
> (174f283)
> *
> engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancer
> LbRuleMapDaoImpl.java (2a6e72b)
> *
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryD
> ataStoreDaoImpl.java (b39f844)
> * framework/db/src/com/cloud/utils/db/DB.java (f83a7ea)
> * framework/db/src/com/cloud/utils/db/GenericDaoBase.java (94e5374)
> *
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/Bareme
> talDhcpDaoImpl.java (8123ee0)
> *
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/Bareme
> talPxeDaoImpl.java (acd7f13)
> *
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java
> (5cb9b02)
> *
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.j
> ava (93c0885)
> *
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/Legac
> yZoneDaoImpl.java (7d2d128)
> *
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/Vmw
> areDatacenterDaoImpl.java (9f5796a)
> *
> plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSM
> DeviceDaoImpl.java (cc25573)
> * plugins/network-
> elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java
> (30dd06d)
> * server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java (266e65f)
> * server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java
> (fd3308d)
> * server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java
> (8162ce8)
> * server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java (ec1a017)
> * server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java
> (a8208dd)
> *
> server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.
> java (d1e8354)
> * server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java
> (103f04e)
> * server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java (562d67d)
> * server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java
> (329931e)
> *
> server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java
> (3357686)
>
> View Diff<https://reviews.apache.org/r/12134/diff/>
>
RE: Review Request 12134: removed txn attribute from DB annotation
Posted by Alex Huang <Al...@citrix.com>.
Kelven and Darren should review this.
That attribute used to be always read to determine if a method should be intercepted at load time. My understanding is the switch to using spring as the injection mechanism caused this to be turned off and now every single method is intercepted, which is terrible. I don’t know if Kelven and/or Darren has any plans to fix this. If they don’t plan on fixing it, then we should just commit it.
--Alex
From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf Of Prasanna Santhanam
Sent: Wednesday, September 4, 2013 9:56 AM
To: Darren Shepherd; Alex Huang
Cc: Prasanna Santhanam; Laszlo Hornyak; cloudstack
Subject: Re: Review Request 12134: removed txn attribute from DB annotation
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/
Review request for cloudstack, Alex Huang and Darren Shepherd.
By Laszlo Hornyak.
Updated Sept. 4, 2013, 4:55 p.m.
Changes
including couple reviewers
Repository: cloudstack-git
Description
The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
- All of this references to txn removed
- Attribute removed from annotation
- Documentation references removed
Diffs
* engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java (5ba65cc)
* engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java (f071cea)
* engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java (cff4cfc)
* engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java (b12fa9d)
* engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java (353402d)
* engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java (b52e373)
* engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java (d3a2409)
* engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java (782ee0d)
* engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java (d732e6f)
* engine/schema/src/com/cloud/host/dao/HostDaoImpl.java (41ee7a7)
* engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java (e7a7b34)
* engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java (01f8861)
* engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java (ea6437d)
* engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java (41f911c)
* engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java (0f83815)
* engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java (bbb9203)
* engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java (b176760)
* engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java (c29c164)
* engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java (3cdd738)
* engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java (1e26a51)
* engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java (16a23dd)
* engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java (7e47239)
* engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java (61fe52a)
* engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java (dba835f)
* engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java (fe435c0)
* engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java (518237d)
* engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java (6560b90)
* engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java (13c37c4)
* engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java (2cda547)
* engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java (4b5f1b9)
* engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java (a992181)
* engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java (ef8237a)
* engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java (7282443)
* engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java (14b2abf)
* engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java (052bae4)
* engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java (bf28410)
* engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java (7c5c9cc)
* engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java (174f283)
* engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java (2a6e72b)
* engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java (b39f844)
* framework/db/src/com/cloud/utils/db/DB.java (f83a7ea)
* framework/db/src/com/cloud/utils/db/GenericDaoBase.java (94e5374)
* plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java (8123ee0)
* plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java (acd7f13)
* plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java (5cb9b02)
* plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java (93c0885)
* plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java (7d2d128)
* plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java (9f5796a)
* plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java (cc25573)
* plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java (30dd06d)
* server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java (266e65f)
* server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java (fd3308d)
* server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java (8162ce8)
* server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java (ec1a017)
* server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java (a8208dd)
* server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java (d1e8354)
* server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java (103f04e)
* server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java (562d67d)
* server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java (329931e)
* server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java (3357686)
View Diff<https://reviews.apache.org/r/12134/diff/>
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/
-----------------------------------------------------------
(Updated Sept. 4, 2013, 4:55 p.m.)
Review request for cloudstack, Alex Huang and Darren Shepherd.
Changes
-------
including couple reviewers
Repository: cloudstack-git
Description
-------
The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
- All of this references to txn removed
- Attribute removed from annotation
- Documentation references removed
Diffs
-----
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 5ba65cc
engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java d3a2409
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 41ee7a7
engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 41f911c
engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java 0f83815
engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java 518237d
engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java 13c37c4
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java bf28410
engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b39f844
framework/db/src/com/cloud/utils/db/DB.java f83a7ea
framework/db/src/com/cloud/utils/db/GenericDaoBase.java 94e5374
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 266e65f
server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
Diff: https://reviews.apache.org/r/12134/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/
-----------------------------------------------------------
(Updated Aug. 30, 2013, 4:23 p.m.)
Review request for cloudstack.
Changes
-------
fresh patch
Repository: cloudstack-git
Description
-------
The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
- All of this references to txn removed
- Attribute removed from annotation
- Documentation references removed
Diffs (updated)
-----
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 5ba65cc
engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java d3a2409
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 41ee7a7
engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 41f911c
engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java 0f83815
engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java 518237d
engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java 13c37c4
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java bf28410
engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b39f844
framework/db/src/com/cloud/utils/db/DB.java f83a7ea
framework/db/src/com/cloud/utils/db/GenericDaoBase.java 94e5374
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 266e65f
server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
Diff: https://reviews.apache.org/r/12134/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12134: removed txn attribute from DB annotation
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12134/#review25742
-----------------------------------------------------------
By now this patch is kind of outdated and needs an update, just wondering what developers think about the idea. Is the txn attribute being planned to use in the future?
- Laszlo Hornyak
On June 27, 2013, 4:34 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12134/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 4:34 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The txn attribute was used often with the DB annotation, but it does not have an effect on the behavior of the code since it is never read.
> - All of this references to txn removed
> - Attribute removed from annotation
> - Documentation references removed
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 8f7826f
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java 3c34023
> engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java f071cea
> engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoImpl.java cff4cfc
> engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java b12fa9d
> engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java 353402d
> engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoImpl.java b52e373
> engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java 782ee0d
> engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.java d732e6f
> engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 810b973
> engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoImpl.java e7a7b34
> engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImpl.java 01f8861
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDaoImpl.java ea6437d
> engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 45a8068
> engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java c55cf28
> engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java bbb9203
> engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoImpl.java b176760
> engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancerDaoImpl.java c29c164
> engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.java 3cdd738
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java 1e26a51
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderDaoImpl.java 16a23dd
> engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java 7e47239
> engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java 61fe52a
> engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl.java dba835f
> engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java fe435c0
> engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java fac35a9
> engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java 6560b90
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a8cb2b3
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java 2cda547
> engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java 4b5f1b9
> engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java a992181
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ef8237a
> engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMapDaoImpl.java 7282443
> engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java 14b2abf
> engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java 052bae4
> engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java f82b511
> engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java 7c5c9cc
> engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java 174f283
> engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancerLbRuleMapDaoImpl.java 2a6e72b
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalDhcpDaoImpl.java 8123ee0
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/BaremetalPxeDaoImpl.java acd7f13
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java 5cb9b02
> plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.java 93c0885
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/LegacyZoneDaoImpl.java 7d2d128
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/VmwareDatacenterDaoImpl.java 9f5796a
> plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java cc25573
> plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java 30dd06d
> server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 2a3b469
> server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java fd3308d
> server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 8162ce8
> server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ec1a017
> server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java a8208dd
> server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java d1e8354
> server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java 103f04e
> server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java 562d67d
> server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 329931e
> server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 3357686
> utils/src/com/cloud/utils/db/DB.java f83a7ea
> utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700
>
> Diff: https://reviews.apache.org/r/12134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>