[GitHub] [spark] rednaxelafx commented on pull request #33260: [SPARK-36047][CORE] Replace the handwriting compare methods with static compare methods in Java code

[GitBox <gi...@apache.org>]

rednaxelafx commented on pull request #33260:
URL: https://github.com/apache/spark/pull/33260#issuecomment-877445849


   LGTM. Makes sense. In general I'd support this kind of refactoring to reduce code duplication.
   
   But just keep in mind that this line of thought can
   - Slow down initial startup performance while the program is still running in the JVM interpreter
   - Slow down peak performance if the method is deep in an inline tree and went over the `MaxInlineLevel`
   So if you're on these two rare ends of the spectrum, adding a level of method invocation can bring surprising slowdowns >_<|||


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org