You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Jörn Kottmann (JIRA)" <ui...@incubator.apache.org> on 2007/03/22 07:59:32 UTC

[jira] Created: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Eclipse PDE nature for org.apache.uima.runtime project
------------------------------------------------------

                 Key: UIMA-355
                 URL: https://issues.apache.org/jira/browse/UIMA-355
             Project: UIMA
          Issue Type: Improvement
          Components: Eclipse plugins
    Affects Versions: 2.2
            Reporter: Jörn Kottmann
            Priority: Minor


Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Adam Lally <al...@alum.rpi.edu>.
On 3/23/07, Jörn Kottmann <ko...@gmail.com> wrote:
> I did a little test, if I add an option to the maven-eclipse-plugin
> which does
> not exist, it ignores this option silently.
>
> So my idea, maybe you are using an older maven version than I
> which simply does not know the pde option and than it ignores
> it also silently.
>
> My version is 2.0.4
>

My version is also 2.0.4, but you got me thinking about version
issues.  I specified in the pom.xml that I wanted to use version 2.3
of the maven-eclipse-plugin, and then everything worked fine!

Previously I had version 2.2.  I'm not really sure how Maven
determines what version to use if you don't specify.

Anyway, I've committed your changes.  Please check that they look OK
to you.  I built the plugin and it seems to work.


Thanks for helping with this,
  -Adam

Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Jörn Kottmann <ko...@gmail.com>.
I did a little test, if I add an option to the maven-eclipse-plugin  
which does
not exist, it ignores this option silently.

So my idea, maybe you are using an older maven version than I
which simply does not know the pde option and than it ignores
it also silently.

My version is 2.0.4


Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Adam Lally <al...@alum.rpi.edu>.
On 3/23/07, Jörn Kottmann <ko...@gmail.com> wrote:
> So the important difference is in the pom.xml.
>
> At the begin the packaging must be changed from pom to jar
> and then it adds the maven-eclipse-plugin pde option.
> Did you see this ?
>
> <packaging>jar</packaging>
>
> ...
>
> <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-eclipse-plugin</artifactId>
>         <configuration>
>                 <manifest>.ignore</manifest>
>                 <pde>true</pde>
>         </configuration>
> </plugin>
>

Yes, the pom file seems to be exactly what you describe.  But mvn
eclipse:eclipse seems to be completely ignoring it. :(

> How do you apply the patch ? With eclipse ?
>

Yes.  I copy your patch to my clipboard, then I right click on
uimaj-ep-runtime and select Team -> Apply-Patch.  I choose
"Clipboard", then on the next page have to select uimaj-ep-runtime
again.  Then  I set "Ignore leading path name segments" to 5 and click
Finish.

> The .ignore file will not be generated but I get a warning which
> says that it does not exist and cannot be changed:
>
> [WARNING] The references manifest file doesn't exist, plugin
> dependencies will not be
> updated: /Users/joern/Documents/uima-dev/uimaj-ep-runtime/.ignore
>
> There is also an info which says that it runs in pde mode:
> [INFO] The Maven Eclipse plugin runs in 'pde'-mode.
>

I don't see any such messages. :(

-Adam

Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Jörn Kottmann <ko...@gmail.com>.
> Also I don't get a .ignore file - should this have been generated from
> mvn eclipse:eclipse?
>
> When you re-checked did you start from a fresh SVN extract and apply
> your patches?

No, I did not find out how to a apply the patch. If I use eclipse for it
does not work.
It only adds new folders and files to my project e.g
Users/joern/Documents/uima-dev/uimaj-ep-runtime/.../assemble-plugin.xml
(bit this file is empty)

But I again checked it careful manually.

So the important difference is in the pom.xml.

At the begin the packaging must be changed from pom to jar
and then it adds the maven-eclipse-plugin pde option.
Did you see this ?

<packaging>jar</packaging>

...

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-eclipse-plugin</artifactId>
	<configuration>
		<manifest>.ignore</manifest>
		<pde>true</pde>
	</configuration>
</plugin>

How do you apply the patch ? With eclipse ?

The .ignore file will not be generated but I get a warning which
says that it does not exist and cannot be changed:

[WARNING] The references manifest file doesn't exist, plugin  
dependencies will not be
updated: /Users/joern/Documents/uima-dev/uimaj-ep-runtime/.ignore

There is also an info which says that it runs in pde mode:
[INFO] The Maven Eclipse plugin runs in 'pde'-mode.

Hope this helps,
Jörn

Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Adam Lally <al...@alum.rpi.edu>.
On 3/23/07, Jörn Kottmann <ko...@gmail.com> wrote:
> > When I apply both of your patches and run mvn eclipse:eclipse, it
> > doesn't seem to work.  My uimaj-ep-runtime plugin is still just a
> > regular Java project, not a PDE project.  Any ideas?
>
> Ok, I re-checked everything, but it works fine on my machine.
>
> Please try eclipse:clean and then again eclipse:eclipse.
> Always refresh the project after you do this.
>
> The PDE project is also a java project it does not look very different,
> it has even the J on the project folder.
> Did you looked manually at the .project file ?
> There you should see the PDE nature.
>

Yes, I've done as you describe, with no luck.  My .project file is this:
<projectDescription>
  <name>uimaj-ep-runtime</name>
  <comment/>
  <projects/>
  <buildSpec>
    <buildCommand>
      <name>org.eclipse.jdt.core.javabuilder</name>
      <arguments/>
    </buildCommand>
  </buildSpec>
  <natures>
    <nature>org.eclipse.jdt.core.javanature</nature>
  </natures>
</projectDescription>

Also I don't get a .ignore file - should this have been generated from
mvn eclipse:eclipse?

When you re-checked did you start from a fresh SVN extract and apply
your patches?

-Adam

Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Jörn Kottmann <ko...@gmail.com>.
> When I apply both of your patches and run mvn eclipse:eclipse, it
> doesn't seem to work.  My uimaj-ep-runtime plugin is still just a
> regular Java project, not a PDE project.  Any ideas?

Ok, I re-checked everything, but it works fine on my machine.

Please try eclipse:clean and then again eclipse:eclipse.
Always refresh the project after you do this.

The PDE project is also a java project it does not look very different,
it has even the J on the project folder.
Did you looked manually at the .project file ?
There you should see the PDE nature.

Jörn

Re: [jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by Adam Lally <al...@alum.rpi.edu>.
Jörn,

When I apply both of your patches and run mvn eclipse:eclipse, it
doesn't seem to work.  My uimaj-ep-runtime plugin is still just a
regular Java project, not a PDE project.  Any ideas?

-Adam

On 3/23/07, Jörn Kottmann (JIRA) <ui...@incubator.apache.org> wrote:
>      [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jörn Kottmann updated UIMA-355:
> -------------------------------
>
>     Attachment: pde2-patch.txt
>
> Patch for the assemble-plugin.xml file.
> It adds the version to the included jar files.
>
> It would also suggest to remove the plugin.xml, its emtpy and not needed.
>
> > Eclipse PDE nature for org.apache.uima.runtime project
> > ------------------------------------------------------
> >
> >                 Key: UIMA-355
> >                 URL: https://issues.apache.org/jira/browse/UIMA-355
> >             Project: UIMA
> >          Issue Type: Improvement
> >          Components: Eclipse plugins
> >    Affects Versions: 2.2
> >            Reporter: Jörn Kottmann
> >            Priority: Minor
> >         Attachments: pde-patch.txt, pde2-patch.txt
> >
> >
> > Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Commented: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483151 ] 

Adam Lally commented on UIMA-355:
---------------------------------

I see that you'e updated the names of the jar files in the manifest.  They used be uima-core.jar, uima-cpe.jar, etc.  Now they are the default Maven names with version number: uimaj-core-2.2-incubating-SNAPSHOT.jar, etc.  I suppose this is necessary to get it to work with the Maven eclipse plugin pde option, but it's unfortunate.  This is yet another place we'd have to remember to change the version number when we're about to release a new version, and it's inconsistent with our jar file naming in the SDK lib directory.  So that makes me al ittle uneasy about doing this.  What do the other committers think?

If we go ahead with this, you will also need to modify assemble-plugin.xml.  This is what determines how the plugin is built as part of the fully UIMA SDK distribution.  It is still putting the jar files under lib, with the old names.



> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Priority: Minor
>         Attachments: pde-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Jörn Kottmann (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jörn Kottmann updated UIMA-355:
-------------------------------

    Attachment: pde-patch.txt

> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Priority: Minor
>         Attachments: pde-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Lally reassigned UIMA-355:
-------------------------------

    Assignee: Adam Lally

> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>         Assigned To: Adam Lally
>            Priority: Minor
>         Attachments: pde-patch.txt, pde2-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Jörn Kottmann (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jörn Kottmann updated UIMA-355:
-------------------------------

    Attachment: pde2-patch.txt

Patch for the assemble-plugin.xml file.
It adds the version to the included jar files.

It would also suggest to remove the plugin.xml, its emtpy and not needed.

> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Priority: Minor
>         Attachments: pde-patch.txt, pde2-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor closed UIMA-355.
-------------------------------


> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Assignee: Jörn Kottmann
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: pde-patch.txt, pde2-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Thilo Goetz (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thilo Goetz updated UIMA-355:
-----------------------------

    Reporter: Jörn Kottmann  (was: Jörn Kottmann)

> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Assignee: Jörn Kottmann
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: pde-patch.txt, pde2-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (UIMA-355) Eclipse PDE nature for org.apache.uima.runtime project

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Lally resolved UIMA-355.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.2
         Assignee: Jörn Kottmann  (was: Adam Lally)

I think this isuse has already been addressed.  Jörn, do you agree?

> Eclipse PDE nature for org.apache.uima.runtime project
> ------------------------------------------------------
>
>                 Key: UIMA-355
>                 URL: https://issues.apache.org/jira/browse/UIMA-355
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Eclipse plugins
>    Affects Versions: 2.2
>            Reporter: Jörn Kottmann
>            Assignee: Jörn Kottmann
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: pde-patch.txt, pde2-patch.txt
>
>
> Add a PDE nature to the org.apche.uima.runtime project with the maven-eclipse-plugin pde option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.