You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/10/20 07:25:03 UTC

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1224: IGNITE-17612 Fix TableScanNode data propagation.

ygerzhedovich commented on code in PR #1224:
URL: https://github.com/apache/ignite-3/pull/1224#discussion_r1000239519


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/TableScanNode.java:
##########
@@ -188,7 +188,7 @@ private void push() throws Exception {
             }
         }
 

Review Comment:
   why not 
   `inBuff.size() < inBufSize` instead of `inBuff.isEmpty()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org