You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:25:00 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #209: Use -fno-common for sim KERNEL build

xiaoxiang781216 commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375064507
 
 

 ##########
 File path: boards/sim/sim/sim/scripts/Make.defs
 ##########
 @@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
 ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
 ARCHSCRIPT =
 
+ifneq ($(KERNEL),y)
 
 Review comment:
   Why skip -fno-common for KERNEL build?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services