You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/19 07:24:37 UTC
[GitHub] [pulsar] lhotari opened a new pull request #11710: [branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks
lhotari opened a new pull request #11710:
URL: https://github.com/apache/pulsar/pull/11710
### Motivation
- backports #11706 to branch-2.7
### Modifications
- include batchBuilder in ProducerSpec -> ProducerConfig.ProducerConfigBuilder conversion since it was missing
- support setting batch builder with "--batch-builder KEY_BASED" argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari edited a comment on pull request #11710: [branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks
Posted by GitBox <gi...@apache.org>.
lhotari edited a comment on pull request #11710:
URL: https://github.com/apache/pulsar/pull/11710#issuecomment-902411109
> Thanks for your contribution. For this PR, do we need to update docs?
@Anonymitaet No. This is a backport of the bug fix #11706 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11710: [branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11710:
URL: https://github.com/apache/pulsar/pull/11710#issuecomment-902377088
Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #11710: [branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #11710:
URL: https://github.com/apache/pulsar/pull/11710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11710: [branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11710:
URL: https://github.com/apache/pulsar/pull/11710#issuecomment-902411109
> Thanks for your contribution. For this PR, do we need to update docs?
@Anonymitaet No. This is a backport of #11706 which already includes the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org