[GitHub] [hadoop] cndaimin commented on a diff in pull request #3982: HDFS-16454:fix inconsistent comments in DataNode

[GitBox <gi...@apache.org>]

cndaimin commented on code in PR #3982:
URL: https://github.com/apache/hadoop/pull/3982#discussion_r846984707


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -2227,14 +2227,14 @@ public void shutdown() {
     // wait reconfiguration thread, if any, to exit
     shutdownReconfigurationTask();
 
-    LOG.info("Waiting up to 30 seconds for transfer threads to complete");
+    LOG.info("Waiting up to 15 seconds for transfer threads to complete");

Review Comment:
   `executorService.awaitTermination(timeout, unit)` will be possibly invoked 2 times in `HadoopExecutors#shutdown`. The time value in log looks ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org