[GitHub] [geode] upthewaterspout commented on a change in pull request #6883: GEODE-9547: Radish commands are authorized by the SecurityManager

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #6883:
URL: https://github.com/apache/geode/pull/6883#discussion_r714112793



##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/connection/AuthIntegrationTest.java
##########
@@ -77,13 +93,15 @@ private void setupCache(boolean withUsername, boolean withSecurityManager) throw
     server = new GeodeRedisServer("localhost", port, (InternalCache) cache);
     server.getRegionProvider().getSlotAdvisor().getBucketSlots();
     this.jedis = new Jedis("localhost", port, 100000);
+
+    System.clearProperty("io.netty.eventLoopThreads");

Review comment:
       Does this need to be in a finally block perhaps?

##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -298,6 +320,23 @@ public boolean isAuthenticated() {
     return (!securityService.isIntegratedSecurity()) || subject != null;
   }
 
+  public boolean isAuthorized() {
+    if (!securityService.isIntegratedSecurity()) {

Review comment:
       Do we need this check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org