You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by nberserk <gi...@git.apache.org> on 2015/07/26 08:28:21 UTC
[GitHub] incubator-zeppelin pull request: add save button to paragraph
GitHub user nberserk opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/168
add save button to paragraph
this pull request add save button to paragraph.
related JIra issue is
https://issues.apache.org/jira/browse/ZEPPELIN-101
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nberserk/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit cbebc8e0aad6d986bc42b998a97a13af2baac208
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:18:31Z
add save button to paragraph toolbar
commit 30b15a1b279c75bf50cc9304d03b22c59251e66f
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:21:52Z
recover prev indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129081367
@corneadoug I agree on that save button is useless with auto-save. good point.
i will
- remove the button
- propose new way to show dirty state for each paragraph
then we don't have to add 'save button'. less button is good for end users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125400344
@felixcheung
@bzz
You are right, the icon is somewhat misleading.
and I will try automatic save after 10s soon.
Thanks for the suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127109589
@nberserk
Personally, I think it's natural to have have single save button when the context continues.
For example, word processor / presentation software have single save button instead of have save button for every pages / slides.
What do you think about this perspective?
About ZEPPELIN-136, i think there're other ways to fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125288858
This is a great change but I'm wondering, is there a reason we couldn't save the paragraph automatically (a la IPython/Jupyter?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128218660
I believe saving per `notebook` makes more sense. As was mentioned, when saving a document we usually save the whole document not per paragraph. Moreover, during physical `persist`, usually the whole document/notebook is persisted. Thus saving per `notebook` is more intuitive as well as resembles the real underlying activities most.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129217441
+1 for color of left vertical bar of code area - it would be more like IDEs
gray star in notebook title is good too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129431192
current screenshot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130113871
Close/reopen the PR.
You might also want to rebase or merge master in that branch since build was fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129336186
@nberserk that vertical bar might not be related to Ace.
Just do a right click > inspect element and check the css to change :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128608674
The (outdated) is slightly different as it shows that the result is not matching the query, especially after query was saved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
GitHub user nberserk reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/168
ZEPPELIN-101, add auto-save paragraph feature
this pull request add save button to paragraph.
related JIra issue is
https://issues.apache.org/jira/browse/ZEPPELIN-101
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nberserk/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit cbebc8e0aad6d986bc42b998a97a13af2baac208
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:18:31Z
add save button to paragraph toolbar
commit 30b15a1b279c75bf50cc9304d03b22c59251e66f
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:21:52Z
recover prev indentation
commit c9cd2e7d328e811f26b04ae95e8793b63c60a16b
Author: Darren Ha <nb...@gmail.com>
Date: 2015-07-28T08:39:35Z
adding save timer
commit b38118cfa856ebbeefc3f4547dcbb8962765d882
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-28T15:21:43Z
add status msg outdated
commit 83a8aefa8bd9947f50b57ed67d4ab34e9495d0a2
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:18:31Z
add save button to paragraph toolbar
commit 78f0168b5e9a1cb19bbd29718d7e76293373fe14
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-26T06:21:52Z
recover prev indentation
commit 92102808a97e7a1d7389518513bad17c2c01823c
Author: Darren Ha <nb...@gmail.com>
Date: 2015-07-28T08:39:35Z
adding save timer
commit 3e85988efde6e9ad44ea8491ef5b30ebfe2c9880
Author: Darren ha <nb...@gmail.com>
Date: 2015-07-28T15:21:43Z
add status msg outdated
commit 250951bc9529d9a469e48e5a1c739ff3cd32ea43
Author: Darren Ha <nb...@gmail.com>
Date: 2015-07-28T23:26:02Z
Merge branch 'master' of https://github.com/nberserk/incubator-zeppelin
merge saveParagraph automatically
commit 71b07f2512560054f916928e4a04e9f0f610aa2d
Author: Darren Ha <nb...@gmail.com>
Date: 2015-07-29T07:45:08Z
fix test failure. move icon to the right
commit 4a62305e525298169a6168dbbe23f9fc478c4625
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-01T23:19:08Z
change icon to floppy-save of awesomefont
commit 56747b197d8e6c683bcb0617dd8d755e075421ce
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-02T06:06:51Z
disable move up/down when unsaved contents to address ZEPPELIN-136
commit 31d143fbc10d337ea47cf8576a72503a83be4fda
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-04T10:57:25Z
Revert "disable move up/down when unsaved contents to address ZEPPELIN-138"
This reverts commit 56747b197d8e6c683bcb0617dd8d755e075421ce.
commit c2d714efad3055fd1cfbb54e8f51264a81aba1a8
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-07T06:57:05Z
Merging 'upstream/master'
commit c05bc257328c63a400e0e218888c74e61f2ebbf2
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-07T14:27:37Z
move save button from paragraph to notebook
commit d6f6e27ee98520c684948a8f09946e9c18c2c1ca
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-09T12:46:58Z
fix outdated logic; show save button always
commit 66cc991dc324603cf43e02330c56bca07b5d309d
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-10T12:51:06Z
show paragraph's dirty state by reddish vertical bar
commit 878d43ee065f1f6dd6d66500299c322891f909f5
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-10T14:19:10Z
less aggressive color for dirty class
commit 7edbef8a428414dc0749f2c82c7b507378d5ea9d
Author: Darren Ha <nb...@gmail.com>
Date: 2015-08-10T23:04:15Z
Merge remote-tracking branch 'upstream/master'
Conflicts:
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
commit 593d119c42ab7da6a3c0b709a719f7a1cbd59c44
Author: Darren Ha <nb...@gmail.com>
Date: 2015-08-11T09:30:24Z
Merge remote-tracking branch 'upstream/master'
commit 5201c15f94a3986463132a8bc905609fe28823fc
Author: Darren ha <nb...@gmail.com>
Date: 2015-08-11T13:55:59Z
Merge branch 'upstream'
Conflicts:
zeppelin-web/src/components/noteName-create/visible.directive.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127808774
@nberserk can you please clarify, how "save button in paragraph" is more dominant?
May be I missed something, please point it out here, but so far me and Moon were expressing opinions about "save per notebook" with concret arguments.
@corneadoug good point, but the closest thing from the text editor with changes, from my experience, is a hot key. If we have a hot key for the per-notebook save action, that means used does not need to switch to mouse to save everything.
This way we do not need to repete same action button ("save notebook" as that's what it is) per every paragraph and complicate UI more, but still give ability to the user to be more productive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127094140
@Leemoonsoo if we don't have save paragraph button, we can't fix [ZEPPELIN-136](https://issues.apache.org/jira/browse/ZEPPELIN-136)
and in UX perspective, after editing paragraph, have to save note. this flow is not intuitive.
and now save is automatically done using $timeout. after saving the button will disappear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129096757
if we `always display paragraph(remove show title option)` title like above, simply adding `*` can be a mark for dirty state.
I would like to hear your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125222035
screenshot attached.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130154084
@nberserk thanks for the great improvements.
I tested this branch and it is working really well. I have two more feedbacks here,
a) When new paragraph is created, it shows `outdated` and this is little bit weird. Because of it's just created and nothing can be outdated.
b) Can we change variable name `textSaved` to something like `dateUpdated` or `dateTextUpdated`?
To have better consistency with the other variable around it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128426011
@khalidhuseynov thank you for the feedback
@corneadoug sorry for miss-leading comment
Save per notebook Is better option in my opinion.
As for indicator of saved/not saved status, it's a good point and AFAK current implementation already has it at in the last line of he paragraph I.e '(outdated)'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130111336
how can i retrigger travis ci ? It seems fail to download bin from maven repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125406040
For an auto save feature, its important not to overcharged the server with calls.
So it should send the save message only if there was changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128618745
ok. then i will move the save button to notebook level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129471071
@tzolov applied less aggressive color. thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125786055
flag icon added to show paragraph text is updated but not saved.
status msg format updated to show this result is 'outdated'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129130158
Gray star in the paragraph (e.g. next to the vertical bar) looks nice to me. But if you go for colored vertical bar then I would prefer a some sort of dimmed alert color:
<img width="459" alt="screen shot 2015-08-09 at 9 27 26 am" src="https://cloud.githubusercontent.com/assets/1351573/9153933/eb26a0d2-3e78-11e5-9cb8-364ca2ec0a3d.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127443617
@Leemoonsoo
@bzz
seems the approach is diverging
- save button in notebook
- save button in paragraph
what's other person's opinion ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127889181
@bzz Actually your comment was in favor of per paragraph button.
Hotkey is way faster indeed, and thanks to auto save feature, you will rarely save using the button. The button could be seen as an indicator that this paragrah is not saved yet (since its only there when changes exist) And you need an indicator on each paragraph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128836246
If the notebook saved button is only used to save dirty queries, then it becomes pretty useless with the auto save:
Considering the autosave every 10s, I doubt somebody will use the note save button (he could use shortcut or wait) and 10s is pretty short. Auto save would probably kick before you reach the button 50% of the time.
Also, it will probably never save more than one paragraph each time (because of 10s auto save).
Having a dirty feedback on paragraph and an outdated feedback on the result is way enough with auto save.
The only drawback with auto save could be query history in case you do wrong changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127109640
Yes, from the UX perspective, isn't it that in any editor you edit the single line or paragraph, but save only the whole file? This is sounds like an quite intuitive flow\mental modet to me.
May be I do not understand something, but why can not we save whole notebook to fix ZEPPELIN-136?
Automatic save by time out is awesome, but having a single, manual, save button per paragraph makes a lot of sense to me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128182041
i thought
me and @bzz @corneadoug said `per paragraph`
@Leemoonsoo said 'per notebook`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125085573
Hi, thanks for the contribution.
Can you please provide a screenshot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127565587
@corneadoug
ok then.
seems `save button in paragraph` is more dominant.
@Leemoonsoo
do you okay with this ?
this pull request does:
1. save timer added; after 10sec `save paragraph` will be invoked
2. save button added; it will not be shown when there is no change.
3. if the paragraph's result is outdated by editing , it will add '(outdated)' msg to the end of execution time description. (see above screenshot)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add
auto-save parag...
Posted by IT CTO <go...@gmail.com>.
@Leemoonsoo , +1 for changing color of left vertical bar of code area. OR
Gray star on paragraph.
Having the marker on the paragraph level indicates what is NOT saved.
On Sun, Aug 9, 2015 at 10:01 AM nberserk <gi...@git.apache.org> wrote:
> Github user nberserk commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129129183
>
> @Leemoonsoo , +1 for gray star in notebook title.
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129129183
@Leemoonsoo , +1 for gray star in notebook title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129312275
+1 for the first screenshot (with the reddish vertical bar). This is a warning for unsafe state and IMO the color should be alerting (e.g. orange or reddish like). My brain doesn't connect blue or darkgray with warnings. But this could be only me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130359331
Thanks! Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-126961706
final screenshot looks like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129467955
@nberserk, i know nothing about UX but perhaps this color (#E67E22) is less aggressive while still evokes warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-128716633
the button is moved to notebook level.
in summary, this pull request does:
1. save timer; after 10sec `saveNote` will be called. `saveNote` will invoke `saveParagraph`. only paragraph has dirty text(delta) will be saved
2. save button in note; save button will not be shown when no change in note
3. if the paragraph's result is outdated by editing , it will add '(outdated)' msg to the end of execution time description. (see above screenshot)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130207950
@Leemoonsoo I've addressed your feedback. seems ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129481115
+1 ;)
On Mon, Aug 10, 2015 at 4:21 PM, darren ha <no...@github.com> wrote:
> @tzolov <https://github.com/tzolov> applied less aggressive color. thanks
> for the feedback.
>
> [image: screen shot 2015-08-10 at 11 19 36 pm]
> <https://cloud.githubusercontent.com/assets/900639/9173629/5c4e6950-3fb6-11e5-82e1-b11f87b5f8d0.png>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129471071>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127492012
I would say paragraph level since its closer from text editor with changes. However autosave is more important in itself than the button, and showing the save button is not needed if there is nothing to change. We could set button at paragraph level for now, and after use we could move it laterif needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add save button to paragraph
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125383530
Great contribution, thank you.
At the first glance I thought it's a download button though.
Might old-school floppy-disc icon be used, or does anybody know better alternatives?
I also have a question: do we need a "save per paragraph" action or shall there be a single "save per notebook" button? Ie it is not uncommon to have 10s of paragraphs in the notebook, and each already have 4 buttons.
Saving automatically more often makes a lot of sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129323059
+1 for reddish vertical bar also. and it simply more pretty.
@Leemoonsoo
can you share the code snippet to change vertical bar of ace editor ?
then i will integrate it with my code base.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-127066071
@nberserk Thanks for the contribution.
What do you think about the save button that @bzz mentioned?
> I also have a question: do we need a "save per paragraph" action or shall there be a single "save per notebook" button? Ie it is not uncommon to have 10s of paragraphs in the notebook, and each already have 4 buttons.
I also think save button per notebook is more make sense than save button per paragraph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-130125802
ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129243001
+1 for color of left vertical bar of code area. as well as gray star in notebook title.
I tried few different color for left vertical bar, to see how it harmonize with the other part of the screen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-101, add auto-save parag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-129127104
I think adding `*` mark for dirty state looks clean and pretty. But hiding title is i think useful for many cases.
I created few mockups with alternatives to see how it'll look like.
Black star
Gray star
Black dot
Gray dot
Other way is changing color of left vertical bar of code area.
Another alternative is put star only on notebook title, like
or
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---