You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by kw...@apache.org on 2016/10/20 06:03:03 UTC
[1/4] incubator-impala git commit: IMPALA-3920: TotalStorageWaitTime
counter not populated for fragments with Kudu scan node
Repository: incubator-impala
Updated Branches:
refs/heads/master b15d992ab -> 502220c69
IMPALA-3920: TotalStorageWaitTime counter not populated for fragments
with Kudu scan node
Currently we do not start the TotalStorageWaitTime timer in the
kudu-scanner. This patch replaces the kudu_read_timer with the
TotalStorageWaitTime which measures the intended time.
Change-Id: If0c793930799fdcaff53e705f94b52cadac2f53a
Reviewed-on: http://gerrit.cloudera.org:8080/4639
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/ef5d0c36
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/ef5d0c36
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/ef5d0c36
Branch: refs/heads/master
Commit: ef5d0c36aa7d681d91f04be0f0a487c9fe402c51
Parents: b15d992
Author: aphadke <ap...@cloudera.com>
Authored: Wed Oct 5 16:51:07 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Wed Oct 19 23:07:47 2016 +0000
----------------------------------------------------------------------
be/src/exec/kudu-scan-node.cc | 3 ---
be/src/exec/kudu-scan-node.h | 3 ---
be/src/exec/kudu-scanner.cc | 4 ++--
3 files changed, 2 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/ef5d0c36/be/src/exec/kudu-scan-node.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/kudu-scan-node.cc b/be/src/exec/kudu-scan-node.cc
index 6e97378..4a162a8 100644
--- a/be/src/exec/kudu-scan-node.cc
+++ b/be/src/exec/kudu-scan-node.cc
@@ -60,7 +60,6 @@ using kudu::Slice;
namespace impala {
-const string KuduScanNode::KUDU_READ_TIMER = "TotalKuduReadTime";
const string KuduScanNode::KUDU_ROUND_TRIPS = "TotalKuduScanRoundTrips";
const string KuduScanNode::KUDU_REMOTE_TOKENS = "KuduRemoteScanTokens";
@@ -95,8 +94,6 @@ Status KuduScanNode::Prepare(RuntimeState* state) {
scan_ranges_complete_counter_ =
ADD_COUNTER(runtime_profile(), SCAN_RANGES_COMPLETE_COUNTER, TUnit::UNIT);
- kudu_read_timer_ = ADD_CHILD_TIMER(runtime_profile(), KUDU_READ_TIMER,
- SCANNER_THREAD_TOTAL_WALLCLOCK_TIME);
kudu_round_trips_ = ADD_COUNTER(runtime_profile(), KUDU_ROUND_TRIPS, TUnit::UNIT);
kudu_remote_tokens_ = ADD_COUNTER(runtime_profile(), KUDU_REMOTE_TOKENS, TUnit::UNIT);
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/ef5d0c36/be/src/exec/kudu-scan-node.h
----------------------------------------------------------------------
diff --git a/be/src/exec/kudu-scan-node.h b/be/src/exec/kudu-scan-node.h
index d4f742a..79ed480 100644
--- a/be/src/exec/kudu-scan-node.h
+++ b/be/src/exec/kudu-scan-node.h
@@ -99,10 +99,8 @@ class KuduScanNode : public ScanNode {
/// Thread group for all scanner worker threads
ThreadGroup scanner_threads_;
- RuntimeProfile::Counter* kudu_read_timer_;
RuntimeProfile::Counter* kudu_round_trips_;
RuntimeProfile::Counter* kudu_remote_tokens_;
- static const std::string KUDU_READ_TIMER;
static const std::string KUDU_ROUND_TRIPS;
static const std::string KUDU_REMOTE_TOKENS;
@@ -136,7 +134,6 @@ class KuduScanNode : public ScanNode {
// have been open previously.
Status GetConjunctCtxs(vector<ExprContext*>* ctxs);
- RuntimeProfile::Counter* kudu_read_timer() const { return kudu_read_timer_; }
RuntimeProfile::Counter* kudu_round_trips() const { return kudu_round_trips_; }
};
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/ef5d0c36/be/src/exec/kudu-scanner.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/kudu-scanner.cc b/be/src/exec/kudu-scanner.cc
index a6affbf..ca4ee9a 100644
--- a/be/src/exec/kudu-scanner.cc
+++ b/be/src/exec/kudu-scanner.cc
@@ -147,7 +147,7 @@ Status KuduScanner::OpenNextScanToken(const string& scan_token) {
"Could not set scanner timeout");
{
- SCOPED_TIMER(scan_node_->kudu_read_timer());
+ SCOPED_TIMER(state_->total_storage_wait_timer());
KUDU_RETURN_IF_ERROR(scanner_->Open(), "Unable to open scanner");
}
return Status::OK();
@@ -335,7 +335,7 @@ Status KuduScanner::KuduRowToImpalaTuple(const KuduScanBatch::RowPtr& row,
Status KuduScanner::GetNextScannerBatch() {
- SCOPED_TIMER(scan_node_->kudu_read_timer());
+ SCOPED_TIMER(state_->total_storage_wait_timer());
int64_t now = MonotonicMicros();
KUDU_RETURN_IF_ERROR(scanner_->NextBatch(&cur_kudu_batch_), "Unable to advance iterator");
COUNTER_ADD(scan_node_->kudu_round_trips(), 1);
[2/4] incubator-impala git commit: IMPALA-4230: ASF policy issues
from 2.7.0 rc3.
Posted by kw...@apache.org.
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. He asked:
1. "Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions."
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Reviewed-on: http://gerrit.cloudera.org:8080/4582
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5a2c50a1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5a2c50a1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5a2c50a1
Branch: refs/heads/master
Commit: 5a2c50a1633d8bc2d848f609e867b324c24fe06c
Parents: ef5d0c3
Author: Jim Apple <jb...@cloudera.com>
Authored: Fri Sep 30 14:29:45 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Wed Oct 19 23:59:02 2016 +0000
----------------------------------------------------------------------
LICENSE.txt | 130 ++++++++++++++++++-
README.md | 10 +-
be/src/codegen/CMakeLists.txt | 7 +
bin/rat_exclude_files.txt | 1 -
fe/src/test/resources/hbase-site.xml.template | 2 -
llvm-ir/test-loop.bc | Bin 1828 -> 0 bytes
.../common/etc/hadoop/conf/hadoop-policy.xml | 2 -
.../etc/hadoop/conf/log4j.properties.tmpl | 2 -
8 files changed, 144 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/LICENSE.txt
----------------------------------------------------------------------
diff --git a/LICENSE.txt b/LICENSE.txt
index eb5990d..4cda0f2 100644
--- a/LICENSE.txt
+++ b/LICENSE.txt
@@ -251,6 +251,47 @@ src/be/gutil/utf: licensed under the following terms:
--------------------------------------------------------------------------------
+src/be/gutil/valgrind.h: licensed under the following terms:
+
+ This file is part of Valgrind, a dynamic binary instrumentation
+ framework.
+
+ Copyright (C) 2000-2008 Julian Seward. All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ 1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+ 2. The origin of this software must not be misrepresented; you must
+ not claim that you wrote the original software. If you use this
+ software in a product, an acknowledgment in the product
+ documentation would be appreciated but is not required.
+
+ 3. Altered source versions must be plainly marked as such, and must
+ not be misrepresented as being the original software.
+
+ 4. The name of the author may not be used to endorse or promote
+ products derived from this software without specific prior written
+ permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS
+ OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+ GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+ WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+--------------------------------------------------------------------------------
+
www/d3.v3.[min.]js: BSD 3-clause license
Copyright (c) 2012, Michael Bostock
@@ -458,6 +499,31 @@ tests/comparison/leopard/static/fonts/glyphicons-halflings*: MIT license
--------------------------------------------------------------------------------
+normalize.css embedded in www/bootstrap/css/bootstrap.css: MIT
+normalize.css embedded in tests/comparison/leopard/static/css/bootstrap.css: MIT
+
+Copyright (c) Nicolas Gallagher and Jonathan Neal
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+--------------------------------------------------------------------------------
+
www/highlight: 3-clause BSD
tests/comparison/leopard/static/css/hljs.css: 3-clause BSD
tests/comparison/leopard/static/js/highlight.pack.js: 3-clause BSD
@@ -521,7 +587,7 @@ shell/ext-py/prettytable-0.7.1: 3-clause BSD
--------------------------------------------------------------------------------
-shell/ext-py/sqlparse-0.1.14: 3-clause BSD
+shell/ext-py/sqlparse-0.1.14 (most parts): 3-clause BSD
Copyright (c) 2009, Andi Albrecht <al...@gmail.com>
@@ -573,6 +639,34 @@ THE SOFTWARE.
--------------------------------------------------------------------------------
+shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py:
+
+Copyright (C) 2011 Jesus Leganes "piranna", piranna@gmail.com
+
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are
+permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this list of
+conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright notice, this list of
+conditions and the following disclaimer in the documentation and/or other materials
+provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
+EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
+TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+--------------------------------------------------------------------------------
+
be/src/thirdparty/mustache: Apache 2.0 license
be/src/expr/hll-bias.h: Apache 2.0 license
shell/ext-py/sasl-0.1.1: Apache 2.0 license
@@ -603,4 +697,36 @@ cmake_modules/FindGTest.cmake: MIT license
--------------------------------------------------------------------------------
-www/jquery/jquery-1.12.4.min.js: MIT license
+cmake_modules/FindJNI.cmake: 3-clause BSD
+
+ Copyright 2001-2009 Kitware, Inc.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ * Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+ * Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+
+ * Neither the names of Kitware, Inc., the Insight Software Consortium,
+ nor the names of their contributors may be used to endorse or promote
+ products derived from this software without specific prior written
+ permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+--------------------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index b7778e9..b90e7c7 100644
--- a/README.md
+++ b/README.md
@@ -23,4 +23,12 @@ visit the [Impala homepage](https://impala.apache.org).
If you are interested in contributing to Impala as a developer, or learning more about
Impala's internals and architecture, visit the
-[Impala wiki](https://cwiki.apache.org/confluence/display/IMPALA/Impala+Home).
\ No newline at end of file
+[Impala wiki](https://cwiki.apache.org/confluence/display/IMPALA/Impala+Home).
+
+## Supported Platforms
+
+Impala only supports Linux at the moment.
+
+## Build Instructions
+
+./buildall.sh -notests
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/be/src/codegen/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/be/src/codegen/CMakeLists.txt b/be/src/codegen/CMakeLists.txt
index 8ae44e0..d002c68 100644
--- a/be/src/codegen/CMakeLists.txt
+++ b/be/src/codegen/CMakeLists.txt
@@ -99,5 +99,12 @@ add_custom_command(
DEPENDS ${IR_NO_SSE_OUTPUT_FILE}
)
+# Run the clang compiler to generate BC for llvm-codegen-test
+add_custom_target(test-loop.bc
+ COMMAND ${LLVM_CLANG_EXECUTABLE} ${CLANG_IR_CXX_FLAGS} ${CLANG_INCLUDE_FLAGS} ${CMAKE_SOURCE_DIR}/testdata/llvm/test-loop.cc -o ${CMAKE_SOURCE_DIR}/llvm-ir/test-loop.bc
+ SOURCES ${CMAKE_SOURCE_DIR}/testdata/llvm/test-loop.cc
+)
+
ADD_BE_TEST(llvm-codegen-test)
+add_dependencies(llvm-codegen-test test-loop.bc)
ADD_BE_TEST(instruction-counter-test)
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/bin/rat_exclude_files.txt
----------------------------------------------------------------------
diff --git a/bin/rat_exclude_files.txt b/bin/rat_exclude_files.txt
index 2a07b68..a27355e 100644
--- a/bin/rat_exclude_files.txt
+++ b/bin/rat_exclude_files.txt
@@ -61,7 +61,6 @@ be/src/testutil/*.pem
fe/src/test/resources/*.xml
fe/src/test/resources/hbase-jaas-client.conf.template
fe/src/test/resources/hbase-jaas-server.conf.template
-llvm-ir/test-loop.bc
testdata/AllTypesError/*.txt
testdata/AllTypesErrorNoNulls/*.txt
*.avsc
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/fe/src/test/resources/hbase-site.xml.template
----------------------------------------------------------------------
diff --git a/fe/src/test/resources/hbase-site.xml.template b/fe/src/test/resources/hbase-site.xml.template
index 7a72924..e17c0b8 100644
--- a/fe/src/test/resources/hbase-site.xml.template
+++ b/fe/src/test/resources/hbase-site.xml.template
@@ -2,8 +2,6 @@
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
<!--
/**
- * Copyright 2010 The Apache Software Foundation
- *
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/llvm-ir/test-loop.bc
----------------------------------------------------------------------
diff --git a/llvm-ir/test-loop.bc b/llvm-ir/test-loop.bc
deleted file mode 100644
index f7b50c1..0000000
Binary files a/llvm-ir/test-loop.bc and /dev/null differ
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
----------------------------------------------------------------------
diff --git a/testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml b/testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
index cc83bc5..db85124 100644
--- a/testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
+++ b/testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
@@ -2,8 +2,6 @@
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
<!--
- Copyright 2011 The Apache Software Foundation
-
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5a2c50a1/testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
----------------------------------------------------------------------
diff --git a/testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl b/testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
index c9bd0ff..aa477d7 100644
--- a/testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
+++ b/testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
@@ -1,5 +1,3 @@
-# Copyright 2011 The Apache Software Foundation
-#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
[4/4] incubator-impala git commit: IMPALA-4269: Codegen merging
exchange node
Posted by kw...@apache.org.
IMPALA-4269: Codegen merging exchange node
This change enables codegen for the tuple row comparator
used in merging-exchange node.
With this change, merging-exchange operator improves by
40% and 50% respectively for primitive_orderby_bigint and
primitive_orderby_all on TPCH-300, speeding up the query by
6% and 11% respectively.
Change-Id: I944b8d52ea63ede58e4dc6fbe6e6953756394d41
Reviewed-on: http://gerrit.cloudera.org:8080/4759
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/502220c6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/502220c6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/502220c6
Branch: refs/heads/master
Commit: 502220c69d483f785632eaf0030babf40be78ff4
Parents: f1f54fe
Author: Michael Ho <kw...@cloudera.com>
Authored: Tue Oct 18 22:37:33 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Thu Oct 20 04:42:09 2016 +0000
----------------------------------------------------------------------
be/src/exec/exchange-node.cc | 12 ++++++++++++
be/src/exec/exchange-node.h | 1 +
2 files changed, 13 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/502220c6/be/src/exec/exchange-node.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/exchange-node.cc b/be/src/exec/exchange-node.cc
index fac2ff5..13522a7 100644
--- a/be/src/exec/exchange-node.cc
+++ b/be/src/exec/exchange-node.cc
@@ -85,10 +85,22 @@ Status ExchangeNode::Prepare(RuntimeState* state) {
AddExprCtxsToFree(sort_exec_exprs_);
less_than_.reset(
new TupleRowComparator(sort_exec_exprs_, is_asc_order_, nulls_first_));
+ if (!state->codegen_enabled()) {
+ runtime_profile()->AddCodegenMsg(false, "disabled by query option DISABLE_CODEGEN");
+ }
}
return Status::OK();
}
+void ExchangeNode::Codegen(RuntimeState* state) {
+ DCHECK(state->codegen_enabled());
+ if (is_merging_) {
+ Status codegen_status = less_than_->Codegen(state);
+ runtime_profile()->AddCodegenMsg(codegen_status.ok(), codegen_status);
+ }
+ ExecNode::Codegen(state);
+}
+
Status ExchangeNode::Open(RuntimeState* state) {
SCOPED_TIMER(runtime_profile_->total_time_counter());
RETURN_IF_ERROR(ExecNode::Open(state));
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/502220c6/be/src/exec/exchange-node.h
----------------------------------------------------------------------
diff --git a/be/src/exec/exchange-node.h b/be/src/exec/exchange-node.h
index f6face4..6feaff3 100644
--- a/be/src/exec/exchange-node.h
+++ b/be/src/exec/exchange-node.h
@@ -46,6 +46,7 @@ class ExchangeNode : public ExecNode {
virtual Status Init(const TPlanNode& tnode, RuntimeState* state);
virtual Status Prepare(RuntimeState* state);
+ virtual void Codegen(RuntimeState* state);
/// Blocks until the first batch is available for consumption via GetNext().
virtual Status Open(RuntimeState* state);
virtual Status GetNext(RuntimeState* state, RowBatch* row_batch, bool* eos);
[3/4] incubator-impala git commit: IMPALA-3420: use gold by default
Posted by kw...@apache.org.
IMPALA-3420: use gold by default
Also pass the flag that enables ld.gold directly to the
compiler. This is understood by both gcc and clang
(if prefixed with -Wl, clang just forwards the flag to ld,
where it is ignored).
Testing:
Did ASAN and debug private builds to validate it works.
Tested shared library, release, ninja and distcc builds locally
as part of my normal workflow.
Change-Id: Ib05c944ced9cdfe54941f4b690574e45a25110a2
Reviewed-on: http://gerrit.cloudera.org:8080/4751
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/f1f54fe6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/f1f54fe6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/f1f54fe6
Branch: refs/heads/master
Commit: f1f54fe65db7d5af2e53b217fb7cb50abe8c50fc
Parents: 5a2c50a
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Thu Oct 13 11:00:00 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Thu Oct 20 03:09:59 2016 +0000
----------------------------------------------------------------------
be/CMakeLists.txt | 2 +-
bin/impala-config.sh | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f1f54fe6/be/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/be/CMakeLists.txt b/be/CMakeLists.txt
index a5cc4d8..a44834a 100644
--- a/be/CMakeLists.txt
+++ b/be/CMakeLists.txt
@@ -47,7 +47,7 @@ SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFI
SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DBOOST_SYSTEM_NO_DEPRECATED")
SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -B $ENV{IMPALA_TOOLCHAIN}/binutils-$ENV{IMPALA_BINUTILS_VERSION}/bin/")
IF($ENV{USE_GOLD_LINKER} STREQUAL "true")
- SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wl,-fuse-ld=gold")
+ SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fuse-ld=gold")
ENDIF()
# On Apple we build with clang and need libstdc++ instead of libc++
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f1f54fe6/bin/impala-config.sh
----------------------------------------------------------------------
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 38bdc69..85bcbfc 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -56,9 +56,8 @@ fi
# If it's 0, Impala will be built with the compiler in the toolchain directory.
: ${USE_SYSTEM_GCC=0}
-# Gold is available on newer systems and a full build with static linking is ~1.5 mins
-# faster using gold. A shared object build using gold is a little faster than using ld.
-: ${USE_GOLD_LINKER=false}
+# Use ld.gold instead of ld by default to speed up builds.
+: ${USE_GOLD_LINKER=true}
# Override the default compiler by setting a path to the new compiler. The default
# compiler depends on USE_SYSTEM_GCC and IMPALA_GCC_VERSION. The intended use case