You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/12 20:09:30 UTC

[GitHub] [solr] dsmiley commented on pull request #938: SOLR-16271: remove wildcard imports

dsmiley commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1182453009

   Thanks for giving this a shot @epugh!
   
   I now remember what I found when Googling how to get Spotless to do this some months ago.  It's this technique used on another project (Geode): `https://apache.googlesource.com/geode/+/refs/tags/rel/v1.11.0/gradle/spotless.gradle`   I like that it's done as a build hook into Spotless's flexibility as opposed to our home-grown validateSourcePatterns.  Maybe we don't need validateSourcePatterns if we have Spotless?  
   
   CC @uschindler  -- when discussing source validations in general, I recall you have strong opinions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org