[jira] [Commented] (AMBARI-15686) Alert Dispatch Scheduling Changes to Support Repeat Tolerance

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225309#comment-15225309 ] 

Hudson commented on AMBARI-15686:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #4592 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4592/])
AMBARI-15686 - Alert Dispatch Scheduling Changes to Support Repeat (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=18449b5b804790c15f0917ccb43b9a8be4bd5ca1])
* ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java
* ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
* ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
* ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
* ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
* ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
* ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java
* ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
* ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
* ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
* ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
* ambari-server/src/main/java/org/apache/ambari/server/state/AlertFirmness.java
* ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
* ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
* ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql


> Alert Dispatch Scheduling Changes to Support Repeat Tolerance
> -------------------------------------------------------------
>
>                 Key: AMBARI-15686
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15686
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-15686.patch
>
>
> When an alert state change is received, its notification will no longer be queued for immediate delivery if the firmness of the alert is SOFT. Instead, notifications will only be created and queued for delivery if the alert firmness is HARD in order to prevent false positives on alerts which have repeat tolerance enabled. 
> Changes Included in this task:
> - Database changes to support HARD/SOFT states to complement repeat occurrence values
> {code}
> CREATE TABLE alert_current (
>   ...
>   occurrences BIGINT NOT NULL DEFAULT 1,
>   firmness VARCHAR(255) NOT NULL DEFAULT 'HARD',
>   ...
> );
> {code}
> - Changes to eventing system to handle alert state changes difference depending on whether the alerts are HARD/SOFT
> - HARD/SOFT Calculations
> -- If an alert is {{AlertState#OK}}, then the firmness is always {{AlertFirmness#HARD}}
> -- If an alert is {{link SourceType#AGGREGATE}}, then the firmness is always {{link AlertFirmness#HARD}}.
> -- Otherwise, the firmness will be {@link AlertFirmness#SOFT} unless the repeat tolerance has been met.
> - Exposure of HARD/SOFT alert states
> {code}
> GET api/v1/clusters/c1/alerts/1
> {
>   "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1",
>   "Alert": {
>     "cluster_name": "c1",
>     ...
>     "repeat_tolerance": 1,
>     "repeat_tolerance_remaining": 0,
>     "occurrences": 8,
>     "firmness": "HARD"
>     ....
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)