You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "David E. Jones (JIRA)" <ji...@apache.org> on 2006/10/01 19:00:22 UTC

[jira] Closed: (OFBIZ-336) Improve complex-alias to handle nulls and defaults

     [ http://issues.apache.org/jira/browse/OFBIZ-336?page=all ]

David E. Jones closed OFBIZ-336.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: David E. Jones

Thanks for your work on this Leon. I applied your patch in SVN rev 451767.

Not having the single quots for non-numeric strings may cause problems, but I guess we'll see how it goes. If necessary we might have to change to something that uses a ? style parameter on the prepared statement.

> Improve complex-alias to handle nulls and defaults
> --------------------------------------------------
>
>                 Key: OFBIZ-336
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-336
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Leon Torres
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: complex-alias-default-value2.patch
>
>
> The idea behind complex-alias is useful for certain things, but the way it works now is not useful.  Suppose you build a simple addition rule.  If any variable in the equation is null, the entire alias resolves to null.
> For example, suppose you create a view entity to report quantities on OrderItem.  The query would be:
> select product_id, (quantity - cancel_quantity) from order_item;
> However if you run this, you'll see that where quantity or cancel_quantity are null, the result is null.  A solution in postgresql is to use the coalesce function to specify a default value:
> select product_id, (coalesce(quantity, 0) - coalesce(cancel_quantity, 0)) from order_item;
> Now the query works.
> So the fix I think is to add another attribute default-value="something".  If the default-value is present, then add the coalesce function.  Not sure whether this is standard sql or not.
> I also encountered this issue for concatenation ||  operator, so I think it affects most operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira