[GitHub] [solr] risdenk commented on a diff in pull request #1176: SOLR-16132: Stop gpg-agent after use

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1176:
URL: https://github.com/apache/solr/pull/1176#discussion_r1020432520


##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -324,6 +327,11 @@ def checkSigs(urlString, version, tmpDir, isSigned, keysFile):
           if line.lower().find('warning') != -1:
             print('      GPG: %s' % line.strip())
 
+      # Make sure to shutdown the GPG agent at the end

Review Comment:
   I think line 323 above is missing `--homedir`...



##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -277,16 +277,19 @@ def checkSigs(urlString, version, tmpDir, isSigned, keysFile):
   if os.path.exists(gpgHomeDir):
     shutil.rmtree(gpgHomeDir)
   os.makedirs(gpgHomeDir, 0o700)
-  run('gpg --homedir %s --import %s' % (gpgHomeDir, keysFile),
-      '%s/solr.gpg.import.log' % tmpDir)
+  gpgLogFile = '%s/solr.gpg.import.log' % tmpDir
+  run('gpg --homedir %s --import %s' % (gpgHomeDir, keysFile), gpgLogFile)

Review Comment:
   This GPG stuff would be nicer to move after testChanges? or maybe in `isSigned`? If we aren't checking `isSigned` do we care about this gpg import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org