You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (JIRA)" <ji...@apache.org> on 2012/05/07 22:18:51 UTC
[jira] [Created] (SHINDIG-1769) getPerson API should handle "-1" as
a user id
Ryan Baxter created SHINDIG-1769:
------------------------------------
Summary: getPerson API should handle "-1" as a user id
Key: SHINDIG-1769
URL: https://issues.apache.org/jira/browse/SHINDIG-1769
Project: Shindig
Issue Type: Improvement
Affects Versions: 2.5.0
Reporter: Ryan Baxter
Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1769) Person API should handle "-1" as a
user id
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1769:
---------------------------------
Attachment: shindig-1769.patch
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Fix For: 2.5.0
>
> Attachments: shindig-1769.patch
>
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270827#comment-13270827 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7699
-----------------------------------------------------------
Ship it!
+1 Looks good to me
- Henry
On 2012-05-08 20:47:26, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-08 20:47:26)
bq.
bq.
bq. Review request for shindig and Henry Saputra.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270036#comment-13270036 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7656
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
<https://reviews.apache.org/r/5055/#comment16870>
With this here is seemed to override whatever was set in the shindig.properties file. I would also like to only set it once if possible so it is less cryptic.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/5055/#comment16871>
Yup missed the "and" in that statement I can do that.
- Ryan
On 2012-05-07 20:59:08, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-07 20:59:08)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269997#comment-13269997 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
This addresses bug SHINDIG-1769.
https://issues.apache.org/jira/browse/SHINDIG-1769
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
Diff: https://reviews.apache.org/r/5055/diff
Testing
-------
Thanks,
Ryan
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1769) Person API should handle "-1" as a
user id
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1769:
---------------------------------
Fix Version/s: (was: 2.5.0)
2.5.0-beta2
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0-beta2
>
> Attachments: shindig-1769.patch
>
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270054#comment-13270054 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
bq. On 2012-05-07 21:43:40, Ryan Baxter wrote:
bq. >
@Stanton this is responses to your comments, sorry, I didn't add them as comments.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7656
-----------------------------------------------------------
On 2012-05-07 20:59:08, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-07 20:59:08)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269998#comment-13269998 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/
-----------------------------------------------------------
(Updated 2012-05-07 20:59:08.081493)
Review request for shindig.
Summary
-------
Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
This addresses bug SHINDIG-1769.
https://issues.apache.org/jira/browse/SHINDIG-1769
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
Diff: https://reviews.apache.org/r/5055/diff
Testing (updated)
-------
Updated unit tests
Thanks,
Ryan
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270058#comment-13270058 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7660
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-05-07 21:58:53, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-07 21:58:53)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1769) Person API should handle "-1" as a
user id
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1769:
---------------------------------
Summary: Person API should handle "-1" as a user id (was: getPerson API should handle "-1" as a user id)
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270891#comment-13270891 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7703
-----------------------------------------------------------
Committed revision 1335800
- Ryan
On 2012-05-08 20:47:26, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-08 20:47:26)
bq.
bq.
bq. Review request for shindig and Henry Saputra.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270807#comment-13270807 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/
-----------------------------------------------------------
(Updated 2012-05-08 20:47:26.896328)
Review request for shindig and Henry Saputra.
Changes
-------
Added Henry.
Henry could you take a quick look?
Summary
-------
Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
This addresses bug SHINDIG-1769.
https://issues.apache.org/jira/browse/SHINDIG-1769
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
Diff: https://reviews.apache.org/r/5055/diff
Testing
-------
Updated unit tests
Thanks,
Ryan
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270055#comment-13270055 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/
-----------------------------------------------------------
(Updated 2012-05-07 21:58:53.065194)
Review request for shindig.
Changes
-------
Nickname is also set to "Anonymous"
Summary
-------
Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
This addresses bug SHINDIG-1769.
https://issues.apache.org/jira/browse/SHINDIG-1769
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
Diff: https://reviews.apache.org/r/5055/diff
Testing
-------
Updated unit tests
Thanks,
Ryan
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1769) Person API should handle "-1" as a
user id
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter resolved SHINDIG-1769.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0
Committed revision 1335800
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0
>
> Attachments: shindig-1769.patch
>
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1769) Person API should handle "-1" as
a user id
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270033#comment-13270033 ]
jiraposter@reviews.apache.org commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7655
-----------------------------------------------------------
Applied the patch and played around with it. Everything looks good. Just looking for some clarification on the inline comments.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
<https://reviews.apache.org/r/5055/#comment16868>
Not sure why this had to move.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/5055/#comment16869>
Can you set the nickname here as well? The spec seems like it wants name and nickname.
"The value for the name and nickname fields can either be blank or set to an appropriate value such as 'Guest', 'Anonymous', etc."
When you don't set nickname, it is not returned in the API response at all, which I don't think constitutes as "blank" per the spec language.
- Stanton
On 2012-05-07 20:59:08, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-07 20:59:08)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
bq.
bq. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SHINDIG-1769) Person API should handle "-1" as a
user id
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter reassigned SHINDIG-1769:
------------------------------------
Assignee: Ryan Baxter
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0
>
> Attachments: shindig-1769.patch
>
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira