You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/19 04:19:01 UTC
[GitHub] [rocketmq] jamesxuhaozhe opened a new pull request #1667: [ISSUE
#1665] Add more unit test for Validators
jamesxuhaozhe opened a new pull request #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667
## What is the purpose of the change
Add more unit test for Validators
## Brief changelog
XX
## Verifying this change
UT passes
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on issue #1667: [ISSUE #1665] Add
more unit test for Validators
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-568987227
@jamesxuhaozhe the Travis failed because the coverage decreased, you can ignore this temporarily, or add more unit tests to improve coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1667: [ISSUE #1665]
Add more unit test for Validators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-567329467
[](https://coveralls.io/builds/27806897)
Coverage decreased (-0.04%) to 50.6% when pulling **e2dffc6161e7c677cdf5a109fb4dd8a6447ab14c on jamesxuhaozhe:develop** into **f8f6fbe4aa7f5dee937e688322628c366b12a552 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] jamesxuhaozhe commented on issue #1667: [ISSUE #1665]
Add more unit test for Validators
Posted by GitBox <gi...@apache.org>.
jamesxuhaozhe commented on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-569175640
@duhenglucky Not sure what is going on, I added even more unit tests like you suggested, but the coverage still dropped. Much appreciated if you can help to take a look at. Just trying to get this pr to merge. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1667: [ISSUE #1665]
Add more unit test for Validators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-567329467
[](https://coveralls.io/builds/27799166)
Coverage decreased (-0.1%) to 50.544% when pulling **dcdb98a473fcd4670acc1ad34082496092d41827 on jamesxuhaozhe:develop** into **f8f6fbe4aa7f5dee937e688322628c366b12a552 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] jamesxuhaozhe commented on issue #1667: [ISSUE #1665]
Add more unit test for Validators
Posted by GitBox <gi...@apache.org>.
jamesxuhaozhe commented on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-569020476
> @jamesxuhaozhe the Travis failed because the coverage decreased, you can ignore this temporarily, or add more unit tests to improve coverage.
Thank you. However, I am still confused. Because if you take a look at the code change I made in this pr. The change did nothing but adding more unit tests. Ideally, the test coverage should increase a little bit. Let me know how should I fix this and if I am missing anything. Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services