You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/03 04:48:54 UTC
[GitHub] [maven-surefire] dependabot[bot] opened a new pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
dependabot[bot] opened a new pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428
Bumps jsr305 from 2.0.3 to 3.0.2.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1008037232
It was my tests ... I will cleanup it
Please look #435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1008264999
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1008034228
@slawekjaranowski
I have the first question regarding the following POM section in the [commit](https://github.com/apache/maven-surefire/pull/428/commits/a6f0bebe66f088075083a9f7e5dd4c8965c6d88e).
```
<execution>
<id>show-test-classpath</id>
<phase>generate-sources</phase>
<goals>
<goal>build-classpath</goal>
</goals>
<configuration>
<includeScope>test</includeScope>
</configuration>
</execution>
```
How it is related to JSR 305? Did the build fail with this upgrade?
You make it for better visibility of the CP in the logs?
The `try-catch` and `printStackTrace` is the same case?
The `toURI().toURL()` or the old class `URL` is a typical warning in IDE. It is a cosmetic change. We can keep it in this PR, I don't mind, but the changes should go to one commit, and the log visibility changes in another commit. And then it would be clear what purpose you have with it and also the history in the Git would be more clear to everybody.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1007242241
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428#issuecomment-1007242241
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #428: Bump jsr305 from 2.0.3 to 3.0.2
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #428:
URL: https://github.com/apache/maven-surefire/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org