You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/09/01 00:13:15 UTC
Re: Review Request 37773: Docker: Adding registry client.
> On Aug. 31, 2015, 8:42 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 456
> > <https://reviews.apache.org/r/37773/diff/7/?file=1059875#file1059875line456>
> >
> > is maxSize being used at all? If not we should remove all references of it.
I added it as part of the external facing interface so that it doesnt change when we add validation of max size.
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review97138
-----------------------------------------------------------
On Aug. 30, 2015, 3:12 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37773/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 3:12 p.m.)
>
>
> Review request for mesos, Lily Chen and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added implementation for docker registry's Get Manifest and Get Blob APIs.
>
>
> Diffs
> -----
>
> src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99
> src/slave/containerizer/provisioners/docker/registry_client.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/registry_client.cpp PRE-CREATION
> src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37773/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>