You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by alexandrelimassantana <gi...@git.apache.org> on 2016/03/14 06:17:51 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

Github user alexandrelimassantana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1212#discussion_r55956795
  
    --- Diff: server/src/com/cloud/server/ManagementServerImpl.java ---
    @@ -3567,7 +3567,17 @@ public boolean deleteSSHKeyPair(final DeleteSSHKeyPairCmd cmd) {
             final Long domainId = cmd.getDomainId();
             final Long projectId = cmd.getProjectId();
     
    -        final Account owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
    +        Account owner = null;
    --- End diff --
    
    Hello @ustcweizhou 
    
    I think this piece of code could be extracted from the deleteSSHKeyPair method. It has gotten a little big from it's past form and further improvements could be done outside of the main "deleteSSHKeyPair" flow if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---