You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by hzbarcea <gi...@git.apache.org> on 2014/11/19 16:06:16 UTC
[GitHub] incubator-brooklyn pull request: [BRROKLYN-91] Upgrade to activemq...
GitHub user hzbarcea opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/349
[BRROKLYN-91] Upgrade to activemq 5.10.0
The current version of activemq is 5.10.0 and 5.7.0 is no longer maintained. There has been a small change in packaging in activemq, activemq-core is replaced by activemq-broker and activemq-client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzbarcea/incubator-brooklyn master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit 84b86f19016bbad83b75cc735030dfb7714e7fea
Author: Hadrian Zbarcea <ha...@apache.org>
Date: 2014-11-19T15:03:59Z
[BRROKLYN-91] Upgrade to activemq 5.10.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-91] Upgrade to activemq...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/349#issuecomment-63727052
There were other missing fixes related to changed mbean names in activemq-5.10.0. I can confirm running (successfully) `ActiveMQIntegrationTest`. All looks good now.
There are other improvements that should be made, such as supporting networks of brokers (and not hardcoding the brokerName=localhost), but I will submit incremental patches for that.
Thanks for the guidance :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BRROKLYN-91] Upgrade to activemq...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/349#issuecomment-63657087
This patch shouldn't have affected the core. I also ran, successfully, full tests before submitting the patch. Can a committer please take a look? I am not sure how to trigger a new jenkins build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BRROKLYN-91] Upgrade to activemq...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/349#issuecomment-63662358
Thanks @hzbarcea !
Agree the failing test `brooklyn.management.ha.HighAvailabilityManagerSplitBrainTest.testDoubleRebindFails` is unrelated to your changes. We'll look into that separately.
You'll also want to change https://github.com/apache/incubator-brooklyn/blob/master/software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQBroker.java#L48 which controls the default ActiveMQ version actually installed by Brooklyn.
Note that asfbot doesn't run the integration tests for actually installing + testing ActiveMQ, so can you please confirm if you've run `ActiveMQIntegrationTest`?
I'm presuming you have already signed the Apache CLA, assuming you are the same Hadrian Zbarcea (ActiveMQ committer listed on https://people.apache.org/committer-index.html#H).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BRROKLYN-91] Upgrade to activemq...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/349#issuecomment-63680155
@aledsage, thanks for the pointer. I missed the changes in ActiveMQBroker.java and running the integration test. Looks like a few more fixes are in order. Will follow up with another patch. And yes, same hadrian.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-91] Upgrade to activemq...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/349#issuecomment-63738023
looks great -- merging
really excited about clustered activemq blueprints, esp figuring out the yaml config key style so complex scenarios can become as easy to deploy as what we've done with the couchbase folks for multi-clusters and replication [1]. let us know how we can help.
[1] https://github.com/apache/incubator-brooklyn/blob/master/usage/launcher/src/test/resources/couchbase-replication-w-pillowfight.yaml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-91] Upgrade to activemq...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---