Re: [PR] [metric] Add cluster_id tag for client metric group [fluss]

["loserwang1024 (via GitHub)" <gi...@apache.org>]

loserwang1024 commented on code in PR #1655:
URL: https://github.com/apache/fluss/pull/1655#discussion_r2386546685


##########
fluss-server/src/main/java/org/apache/fluss/server/tablet/TabletServer.java:
##########
@@ -202,7 +202,10 @@ protected void startServices() throws Exception {
             // rpc client to sent request to the tablet server where the leader replica is located
             // to fetch log.
             this.clientMetricGroup =
-                    new ClientMetricGroup(metricRegistry, SERVER_NAME + "-" + serverId);
+                    new ClientMetricGroup(
+                            metricRegistry,
+                            ServerMetricUtils.validateAndGetClusterId(conf),
+                            SERVER_NAME + "-" + serverId);

Review Comment:
   It seems more like `server_id` rather than `cluster_id`? Different server in same cluster will collect different viriable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org