You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/22 11:14:19 UTC
[GitHub] [netbeans] mbien opened a new pull request #3658: added java module flag list.
mbien opened a new pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658
this PR is in search for a repository :)
(see https://github.com/apache/netbeans-jenkins-lib/pull/53, https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/2)
JVMs of JDK 16+ require this list to run NetBeans. This means we need it in netbeans.conf (already there), in CI configs, local junit tests and in maven archetypes and/or project templates.
Having it in the repo is most likely the best place for it, it has to evolve with the code + everything can refer to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien merged pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1048303151
Well shall we create one for each cluster? I mean, I do not think that a platform application needs to packages related to javac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1050459292
moved files into new folder + added README as requested
I renamed the files and properties so that it won't be confused with module dependencies or similar.
edit: looks like i have to remove the "metabuild." prefix of the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1056894682
planning to merge this PR this weekend. Speak up if there are more change requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1057265893
Looks good, but as I expected, they're failing RAT tests. The files (or file extension and/or folder) need adding in to the "no degree of creativity" section of the RAT exclusions - https://github.com/apache/netbeans/blob/master/nbbuild/rat-exclusions.txt#L56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1048539692
@ebarboni @neilcsmith-net done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049338665
> I'm not sure what we gain from splitting this into multiple file instead of using real property files with comments.
properties need parsing, a text file needs only simple tokenizing which should simplify usage outside of java programs. CI going to need a horizontal line without -J (probably generated by bash), maven files (archetypes) might want a vertical version like here (probably generated by freemarker): https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/2/files#diff-976f3bd796e4d3a6bb6bdb1d39336860e7bc4d10b9ad93ebca24e01db902cc4f allows copy+paste for users too etc.
> As a stop gap ok.
thats what it is yes. I don't think I have to remind anyone that NB has several JDK 17 compatible releases out by now, but not a single job runs on it so far. The maven archetypes for platform or plugins don't work either, starting NB dev builds from the IDE will also only work up to JDK 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1047863499
OK with me, although my preference would be for the code to template `nb/ide.launcher/netbeans.conf ` to be a second commit in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1050459292
moved files into new folder + added README as requested
I renamed the files and properties so that it won't be confused with module dependencies or similar declarations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1057265893
Looks good, but as I expected, they're failing RAT tests. The files (or whole folder) need adding in to the "no degree of creativity" section of the RAT exclusions - https://github.com/apache/netbeans/blob/master/nbbuild/rat-exclusions.txt#L56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1047855224
for me is ok but we should have another PR to make nbbuild/build.xml alter nb/ide.launcher/netbeans.conf cli add-**** with the content of this file. To keep synchro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1050459292
moved files into new folder + added README as requested
I renamed the files and properties so that it won't be confused with module dependencies or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049515048
> ASF requires copyright headers, so parsers would at least be able to skip comments list (which in turn raises the question how the comment format should look like)
that is new to me. Even the [FAQ](https://www.apache.org/foundation/license-faq.html#Apply-My-Software) says "It is also **valuable** to tag each of your source-code files **in case they become detached** from the LICENSE file." This isn't even source code, just a list of JVM flags. But if the NB repo has stricter rules, I am ok with making it a java properties file, but this will likely complicate use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1048310829
> Well shall we create one for each cluster? I mean, I do not think that a platform application needs to packages related to javac.
if its an IDE plugin it does need the list in the maven config of the unit tests for example. We can make this arbitrarily granular, e.g add a perfect list to every single module but i don't have the time for that unfortunately. Lets start somewhere.
> OK with me, although my preference would be for the code to template `nb/ide.launcher/netbeans.conf ` to be a second commit in this PR.
I agree. Would be good to have at least one place synced up with this PR. I take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049064935
I'm not sure what we gain from splitting this into multiple file instead of using real property files with comments. In the end we will need a real solution, where the platform allows opening packages at runtime (java.base might be problematic). @jlahoda has a prototype here:
https://github.com/apache/netbeans/pull/291
I have looking into that on my "when I find time" list....
As a stop gap ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1059534001
@neilcsmith-net added it to the ignore list, everything is green -> merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049505647
> > I'm not sure what we gain from splitting this into multiple file instead of using real property files with comments.
>
> properties need parsing, a text file needs only simple tokenizing which should simplify usage outside of java programs.
- ASF requires copyright headers, so parsers would at least be able to skip comments list (which in turn raises the question how the comment format should look like)
- There might be the need to add further information. We have seen that at different places in the codebase. If the binaries-list format (the list of external binary files) would have been a structured format it would be less of a hack to parse it and we'd not guess that the target is a maven reference and/or we could trivially add a different checksum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1048434930
@lkishalmi I split the list into four categories, I think this could be a good compromise, what do you think?
Btw the only reason why I didn't make it a properties file is because i think a simple list makes it easier to parse outside of a java program.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049515048
> ASF requires copyright headers, so parsers would at least be able to skip comments list (which in turn raises the question how the comment format should look like)
that is new to me. Even the [FAQ](https://www.apache.org/foundation/license-faq.html#Apply-My-Software) says "It is also **valuable** to tag each of your source-code files in case they become detached from the LICENSE file." This isn't even source code, just a list of JVM flags. But if the NB repo has stricter rules, I am ok with making it a java properties file, but this will likely complicate use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3658: added java module flag list.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3658:
URL: https://github.com/apache/netbeans/pull/3658#issuecomment-1049665410
We don't need license headers here. We already have a bunch of RAT exceptions for files with no degree of creativity - https://www.apache.org/legal/src-headers.html#faq-exceptions These may need adding there though?
If we're going to have multiple files, maybe put them in a subfolder? Could include comments on how they're used and where in a short readme file instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists