You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dnhatn (via GitHub)" <gi...@apache.org> on 2024/09/18 17:29:56 UTC
[PR] Copy stored fields during flush with index-sort [lucene]
dnhatn opened a new pull request, #13803:
URL: https://github.com/apache/lucene/pull/13803
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Copy stored fields during flush with index sort [lucene]
Posted by "dnhatn (via GitHub)" <gi...@apache.org>.
dnhatn closed pull request #13803: Copy stored fields during flush with index sort
URL: https://github.com/apache/lucene/pull/13803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Copy stored fields during flush with index sort [lucene]
Posted by "dnhatn (via GitHub)" <gi...@apache.org>.
dnhatn commented on PR #13803:
URL: https://github.com/apache/lucene/pull/13803#issuecomment-2418198002
I ran the benchmarks multiple times, but the improvement seems to be more noise than a real gain, so I'm closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Copy stored fields during flush with index sort [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #13803:
URL: https://github.com/apache/lucene/pull/13803#issuecomment-2363335011
Oh, interesting. I'm curious if you are able to quantify some speedups, e.g. by modifying luceneutil's StoredFieldsBenchmark (https://github.com/mikemccand/luceneutil/blob/main/src/main/perf/StoredFieldsBenchmark.java) to enable an index sort and measure the speedup?
Do we have good existing tests for this optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Copy stored fields during flush with index sort [lucene]
Posted by "dnhatn (via GitHub)" <gi...@apache.org>.
dnhatn commented on PR #13803:
URL: https://github.com/apache/lucene/pull/13803#issuecomment-2361154788
@jpountz I tried using merges for this, but it didn't work because merges expect the documents to be already sorted by index sorts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org